Advertised broker address about pulsar

[merlimat]

Yes, having both gives the most flexibility, and please go ahead in removing bindOnLocalhost.

[merlimat]

I'm not a big fan of setting the hostname to bind on the config file, since it would require to have a different config file on each host.

What about a setting to advertise the broker address with just the IP ?

Eg: something like :

# Control whether the broker should advertise itself by using the hostname
# or its own IP address. 
advertiseBrokerWithHostname=false

[radekg]

This will not work on EC2, the public IP address is not available via ifconfig. Broker would always advertise private 10.x.x.x address. What about doing it similar to how Kafka does it?

# If set, broker will advertise to discovery using this address;
# if empty, broker will advertise using the hostname, unless bindOnLocalhost
advertiseBrokerAddress=<ip address or hostname>

Yet to figure out this will work if the broker binds on the hostname. It might be a good idea to allow people set the bind address / host. For example:

# to bind on all interfaces, set to 0.0.0.0
brokerBindAddress=<ip or hostname>

What do you think?

[merlimat]

Oh, I see. Then your proposal sounds good.

[radekg]

Shall I target for brokerBindAddress and advertiseBrokerAddress? This might deprecate the bindOnLocalhost as the user could do brokerBindAddress=localhost # or 127.0.0.1.

[radekg]

@merlimat Please see attached PR. I went for brokerAddress and advertisedAddress as these settings relate to broker.conf file.