Coder Social home page Coder Social logo

Comments (6)

lhotari avatar lhotari commented on July 21, 2024 1

@visortelle do you have a chance to check this one? thanks!

from pulsar.

visortelle avatar visortelle commented on July 21, 2024 1

@illegalnumbers this doc page was removed for newer versions.

You can find the pulsar-admin CLI reference here ➡️
https://pulsar.apache.org/reference/#/next/pulsar-admin/


2.10.x support period ended a year ago therefore I think we shouldn't handle it.

If it makes sense, we could make a HEAD request to the suggested URL to check if it is broken. And if the page doesn't exist, don't show the latest version suggestion link.

from pulsar.

illegalnumbers avatar illegalnumbers commented on July 21, 2024

@visortelle I disagree with your assessment of the issue. This page is still up and publicly available. Most search links to anything pulsar related links to 2.x versions or to older 3.x versions rather than next. In fact, the reason I used that in the first place is because it was the first link returned from Google.

It is myopic to consider that just because the support period has ended that the pages are removed and no one will find them. Additionally, this redirect should just work. Old versions of docs should link to new versions.

from pulsar.

visortelle avatar visortelle commented on July 21, 2024

Most search links to anything pulsar related links to 2.x versions or to older 3.x versions rather than next.

There were attempts to fix it in the past. It improved the situation a bit, but not completely. We probably should make one more attempt to exclude old version pages from the Google index.

apache/pulsar-site#506
#17898

Additionally, this redirect should just work.

This page doesn't exist anymore.
Do you suggest handling each such case individually? I mean instead of simply removing pulsar-admin.md file, leave it and add a message that the page has been moved, or this page isn't relevant for newer Pulsar versions (Say Hi! to Pulsar SQL)

We can introduce a way to override the version suggestion message and link on a per-page basis.

Handling it properly looks like a task for one or two full days. @illegalnumbers your GitHub profile says that you work in SN. Maybe you're ready to review all the docs pages across all the versions? Unfortunately, I don't have time to do it for free.

from pulsar.

lhotari avatar lhotari commented on July 21, 2024

A quick hack could be to add some reasonable page as the redirect target.
Redirects could be made with Apache httpd syntax in https://github.com/apache/pulsar-site/blob/main/static/.htaccess
@illegalnumbers any suggestions for the redirect target in this case?

from pulsar.

lhotari avatar lhotari commented on July 21, 2024

Reopening since the "not found" page isn't nice. We can keep this open for contributions.

from pulsar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.