Coder Social home page Coder Social logo

Comments (2)

rdhabalia avatar rdhabalia commented on July 19, 2024 1
  • Mark dynamic settings with an annotation in ServiceConfiguration : [Yes, Included in commit]
  • Have a way to register for config changes events (this may be useful for certain class of variables) [Yes, Included in commit]
  • Otherwise, just read the "dirty" value from the ServiceConfiguration instance (don't store it in local variable and don't use any mutex [Have done similar change]
  • Add a REST handle to change key/value pairs, that only accept variables marked as dynamic [Yes, Included in commit]
  • Store all dynamically configured variables in a single z-node in "properties" format [Yes, Included in commit]
  • At startup log the content of that z-node and log each time a change is detected [Yes, Will do]

This commit includes almost all above suggestions. Once you review and if you think it is fine then I will go ahead and complete full changes.

from pulsar.

merlimat avatar merlimat commented on July 19, 2024

Few random ideas (haven't looked at the code yet):

  • Mark dynamic settings with an annotation in ServiceConfiguration
  • Have a way to register for config changes events (this may be useful for certain class of variables)
  • Otherwise, just read the "dirty" value from the ServiceConfiguration instance (don't store it in local variable and don't use any mutex
  • Add a REST handle to change key/value pairs, that only accept variables marked as dynamic
  • Store all dynamically configured variables in a single z-node in "properties" format
  • At startup log the content of that z-node and log each time a change is detected

from pulsar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.