Possible bug around empty query_params when filter is present about openwhisk-package-cloudant

[csantanapr]

@eweiter

recent fix for validating the "query_params" to be correct JSON.

Can you point to a PR or commit in this repo that you are referring to this?

when they would supply {} as their "query_param"

I would consider this user/client error, as if there is no parameters the query_param should be specified.
I guess we could take a look at improving the validation of query_param to make sure is a JSON object and that is not empty.

Do you have a series of steps using the CLI to reproduce the error so we are clear what are you doing to see this problem?

@jasonpet Could you take a look at this when you have a chance.

[eweiter]

@csantanapr
This is the PR: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/164/files
The user said that they used to create their trigger simply with
bx wsk trigger create <trigger-name> --feed /$IBMCLOUD_ORG_$space/<db-binding>/changes -p dbname <db> -p filter document-updates/new
But now the server returns an error "Invalid JSON for query_params" so they started including the {} and their filter doesn't work.

That is the extent that I know. Jason and I have spoken and he is picking it up to see if we have an issue here.

[jasonpet]

looks like a regression due to PR 164. query_params should not be required.

[jasonpet]

@csantanapr - this can be closed. PR #166 fixed this.