Comments (3)
I'd like to have a look concerning braces, but I'm not sure if I beat a dead horse. If someone is successful with a more common tool (as discussed on mailing list) all the work would become obsolete suddenly.
from nuttx.
@johannes-nivus It is important that we document shortcomings in nxstyle, whether we fix them or not. In order to implement this particular feature, some minimal syntax parsing would be required; I am not sure we want to go that route. But we definitely need an issue in place to remind us that not all coding standard issues are addresses.
There are many, many things that are not checked by nxstyle. Some that come to mind:
Non-local scope (global) varialbes must begin with g_
Structure names must end with _s, union names must end with _u, enumeration names must end with _e, typedef'e names must end with _t
All identifiers are local case except the pre-processor names are all upper case.
etc.
There are more coding standard issues that are NOT addressed than there are coding standard issues addresses. I am not familiar with any automated pretty printer than can fix such things either.
from nuttx.
@johannes-nivus It is important that we document shortcomings in nxstyle, whether we fix them or not. In order to implement this particular feature, some minimal syntax parsing would be required; I am not sure we want to go that route. But we definitely need an issue in place to remind us that not all coding standard issues are addresses.
There are many, many things that are not checked by nxstyle. Some that come to mind:
Non-local scope (global) varialbes must begin with g_
How about stdin/stdout/stderr? any naming rule will have exception, but the standard has the high priority than coding style.
Structure names must end with _s, union names must end with _u, enumeration names must end with _e, typedef'e names must end with _t
But we need smart here: any struct/union/enum/typedef defined by the standard need to keep as before.
All identifiers are local case except the pre-processor names are all upper case.
etc.There are more coding standard issues that are NOT addressed than there are coding standard issues addresses. I am not familiar with any automated pretty printer than can fix such things either.
from nuttx.
Related Issues (20)
- speed up CI checks HOT 4
- Adding Board Support in Nuttx: Steps and Requirements HOT 4
- mkrd fail in rc.sysinit HOT 5
- SIM is mounting /tmp as vfat instead of using TMPFS
- NSH I/O redirection and I/O operation doesn't work and incomplete HOT 2
- Cannot Run ESP32C6-devkitm HOT 4
- GitHub Status: Disruption in service with some Redis clusters Jul 31, 2024
- Add esp32c6 power manager feature HOT 3
- [BUG] Just a test HOT 1
- [BUG] kasan read access error in umm_initialize HOT 9
- [BUG] Running lm3s6965-ek:qemu-protected with gdb-multiarch is crashing HOT 5
- [HELP] ESP32 chip revision ERROR HOT 2
- [BUG] ESP32C6 DevKitM spi issue HOT 17
- [FEATURE] Extensible PL011 UART driver HOT 3
- [HELP] Cannot debug esp32c6 using open ocd HOT 8
- [HELP] prompts "undefined referenc to `_impure_prt`" HOT 6
- [FEATURE] Add support for better pre-commit HOT 2
- [HELP] Register setting during booting the OS on ARM A53 FVP HOT 2
- [HELP] Recreating symlinks/switching directory (configure) HOT 3
- [HELP] FFI compatiblity issues HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nuttx.