Elf loader sample app doesn't build about nuttx-apps

[btashton]

@xiaoxiang781216 I agree that we should move more of this code into a single place, but for now I added a fully functional configuration for his board. This is also helpful for me because I do not have the other boards that use this configuration so I can better test this in the future.

I also want to work on getting these features added into the new documentation as well.

[kernelgurumeditation]

@btashton, thanks for fixing it.

PS: I fixed the USB HOST OTG port for this board, if you want the fix I can send it.

[btashton]

@kernelgurumeditation which configuration are you trying this with? There are some examples such as spresense:elf that I can confirm build. You can find that config here boards/arm/cxd56xx/spresense/configs/elf/defconfig

[kernelgurumeditation]

hi @btashton ,

thanks for the reply,

I'm trying with nucleo-h743zi/nsh and enabling the Elf support and the Elf loader sample App... should it not work?

I had a look at the spresense/configs/elf/defconfig file, and there is no option difference that would explain the failure...

Is this an issue with the link scripts?

Thanks

[btashton]

That is helpful, I have that board, I will try to do a functional test this evening.

[patacongo]

There are changes needed to the nucleo-h743zi/scripts/Make.defs file as well. See diff stm32h7/nucleo-h743zi/scripts/Make.defs cxd56xx/spresense/scripts/Make.defs Here are some necessary additions: 72a79,103 # Loadable module definitions CMODULEFLAGS = $(CFLAGS) -mlong-calls # --target1-abs LDMODULEFLAGS = -r -e module_initialize ifeq ($(CONFIG_CYGWIN_WINTOOL),y)    LDMODULEFLAGS += -T "${shell cygpath -w $(TOPDIR)/libs/libc/modlib/gnu-elf.ld}" else    LDMODULEFLAGS += -T $(TOPDIR)/libs/libc/modlib/gnu-elf.ld endif # ELF module definitions CELFFLAGS = $(CFLAGS) CXXELFFLAGS = $(CXXFLAGS) LDELFFLAGS = -r -e main ifeq ($(CONFIG_CYGWIN_WINTOOL),y)    LDELFFLAGS += -T "${shell cygpath -w $(BOARD_DIR)$(DELIM)scripts$(DELIM)gnu-elf.ld}" else    LDELFFLAGS += -T $(BOARD_DIR)$(DELIM)scripts$(DELIM)gnu-elf.ld endif The latter ELF definitions are certainly necessary.

…

On 11/19/2020 12:00 PM, Nuno Felicio wrote: hi @btashton <https://github.com/btashton> , thanks for the reply, I'm trying with nucleo-h743zi/nsh and enabling the Elf support and the Elf loader sample App... should it not work? I had a look at the spresense/configs/elf/defconfig file, and there is no option difference that would explain the failure... Is this an issue with the link scripts? Thanks — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#481 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABFUG6TU4YE5FVH22Z3FPKLSQVMKXANCNFSM4TXY3IMA>.

[xiaoxiang781216]

But, it's the wrong direction to duplicate the common setting to individual Make.defs. I have saw many people complain some advanced features don't work(e.g. elf, c++...), just because Make.defs doesn't have the necessary options. We need fix the problem for all boards in a common way, otherwise people will complain again and again.
BTW, the user is very hard to add the setting by self if he/she isn't an expert in the related field.

[kernelgurumeditation]

Well, talking as the new Guy..... my main issue is not knowing what is expected to work. This is an RTOS, not windows, typically the ppl who search/work on this is not expecting all to work... but we would like to know, what is expected to work... What is very interesting for me regarding NuttX is being a Posixish system and having a shell makes it very comfortable for a Unix guy like me, and it's really amazing what this little OS can do :) PS: I tried to replicate the Make.defs settings and it didn't fix it...

…

On Fri, Nov 20, 2020 at 2:43 AM Xiang Xiao ***@***.***> wrote: But, it's the wrong direction to duplicate the common setting to individual Make.defs. I have saw many people complain some advanced features don't work(e.g. elf, c++...), just because Make.defs doesn't have the necessary options. We need fix the problem for all board, otherwise people will complain again and again. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#481 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEXNEXI2BMNFF4K72T2AIGLSQXJVPANCNFSM4TXY3IMA> .

[btashton]

Sure I'm happy to review it. I really want to pull some of the common board logic out so we don't have to keep copy pasting it for every variant, but that will take some time.

I'll probably also add the ethernet support since that is also not yet implemented for the board.

[kernelgurumeditation]

Ok @btashton ,
it's at apache/nuttx#2353
Not pretty but works, and can be useful to someone :)