Comments (3)
Since ./mvnw spotless:apply
is a simple fix to formatting problems and it is mentioned in the error message, I don't see the need for a sophisticated formatting mechanism.
from logging-log4j2.
A quick skim shows that this repository refuses to build with anything other than java 11:
Line 315 in 59275a9
Java 11 reached EOL in September and my employer just replaced Java 11 with Java 21.
My computer's default version of java is 21. It's true that I still have a couple of jdk11s installed, but I should garbage collect them.
When playing in the GitHub ecosystem, it's really nice to drive-by contributors if your CI cycles provide outputs for things you've already spent gobs of cycles on so that others don't have to waste their time regenerating them. This is one of those things. And trust me, I spent gobs of time trying to get the spelling PR ready for this repository banging my head against spotless.
Not to point fingers, but your responses to my requests have been incredibly counterproductive. I asked a simple question based on the fact that I had seriously tried and failed to get things to work and you gave a response that didn't work:
#613 (comment)
I'm asking for something simple for which I'm very willing (and able!) to provide an implementation.
Anyway, I've wasted quite a bit of time on this repository, so when someone is open to assisting me in contributing, I'm available to contribute, until then, I'm writing this repository off.
from logging-log4j2.
Yes, we are aware of the Java 11 limitation (cf. #1851). The only reason it is in place is because some tests are failing with JDK 17 (and even more with JDK 21).
Remark that due to your comments:
- we have fixed Spotless so that it works with every module (including
log4j-bom
, which didn't have a Spotless configuration), - we have formatted the entire source code using it, so that contributors are not asked to reformat code they did not modify,
- recently we reformatted everything again with a deterministic formatter (palantir-java-format).
So I wouldn't say you wasted your time writing those comments.
from logging-log4j2.
Related Issues (20)
- The `log4j2.messageFactory` property is ignored since 2.23.0 HOT 1
- Log messages with partially missing parameters HOT 2
- Split off XML configuration into its own module or internal package HOT 1
- log4j-spring-boot gives error HOT 7
- Pass `LogEvent` to `NoSqlConnection#insertObject` HOT 14
- The log file opening flag changed after the log was rotated. HOT 1
- Consider direct transfer of `MutableLogEvent` between threads 3.x
- Ensure used XML configuration complies with the auto-generated XSD
- `PropertiesUtil` fails due to blank key lookup HOT 6
- Run environment-independent tests in full parallel mode
- After modularization of Log4j2, loading the plugin (PluginManager. addPackage) fails HOT 2
- Threads contention because of OutputStreamManager.writeBytes HOT 9
- Lambda expressions compiled with a previous version of `org.apache.logging.log4j.util.Supplier.java` or `MessageSupplier` fail to generate HOT 7
- spring boot 3.2.4 + spring-boot-starter-log4j2 + spring-boot-starter-undertow HOT 2
- Remove `log4j-1.2-api` from 3.x
- Provide a programmatic way to enable/disable log4j2 JMX beans creation HOT 4
- Log4J in desktop application HOT 2
- Use non-commercial host for SslConfigurationTest HOT 1
- [MS13] Automate website deployment
- Fix links on web site HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from logging-log4j2.