complete already: DefaultPromise about dubbo

[AlbumenJ]

@icodening @EarthChen PTAL

[iJIAJIA]

@AlbumenJ
我断点看了下, 3.2.9在初始化NettyConnectionClient时, 新增了

private void initBootstrap() {
        ...
        nettyBootstrap.handler(new ChannelInitializer<SocketChannel>() {
            @Override
            protected void initChannel(SocketChannel ch) {
                ...
                ch.closeFuture().addListener(channelFuture -> doClose());
                // TODO support Socks5
            }
        });
        this.bootstrap = nettyBootstrap;
    }

consumer接收到实例下线时通知时, 会触发一次Invoker#destory方法, 此时会执行一次 AbstractConnectionClient#release, 这里会执行第一次NettyConnectionClient#close方法.
之后释放连接时, 会由Netty的closeFuture触发第二次#close方法.

可以加个判断修复

@Override
    protected void doClose() {
        // AbstractPeer close can set closed true.
        if (isClosed()) {
            if (LOGGER.isDebugEnabled()) {
                LOGGER.debug(String.format("Connection:%s freed ", this));
            }
            final io.netty.channel.Channel current = getNettyChannel();
            if (current != null) {
                current.close();
            }
            this.channel.set(null);
           // 已经触发过一次close通知, 不需要再执行
            if(!closePromise.isSuccess()) {
                closePromise.setSuccess(null);
            }
        }
    }

[AlbumenJ]

Can you please submit a PR?

[icodening]

@AlbumenJ 我断点看了下, 3.2.9在初始化NettyConnectionClient时, 新增了

private void initBootstrap() {
        ...
        nettyBootstrap.handler(new ChannelInitializer<SocketChannel>() {
            @Override
            protected void initChannel(SocketChannel ch) {
                ...
                ch.closeFuture().addListener(channelFuture -> doClose());
                // TODO support Socks5
            }
        });
        this.bootstrap = nettyBootstrap;
    }

修改成ch.closeFuture().addListener(channelFuture -> close());就好了呗，预期结果应该是不会进入两次doClose的逻辑