AppVeyor CI is failing because of newer MSBuild getting selected about cordova-windows

[raphinesse]

Sure! Seems sensible, judging from what you wrote above. If a fair amount of tests are affected, you might even want to factor above snippet out into a function, so you only have a one-liner in the affected tests. Something like skipIfUsingVS2017().

[janpio]

Reason behind this is probably that VS17 does not support building for Windows 8.1 any more, so by fixing the VS detector to pick up the correct VS17 install, we broke the 8.1 builds that still are always tested.

Solution might be to separate the Win10 and Win8.1 tests and only run the matching ones?

[janpio]

Another solution might be to use pending similar to

cordova-windows/spec/e2e/endtoend.spec.js

Lines 218 to 220 in 585dc2f

	if (process.env.APPVEYOR_BUILD_WORKER_IMAGE === 'Visual Studio 2017') {
	pending('This test is broken for VS 2017 on AppVeyor');
	}

in all the Windows 8.1 tests. Does that make sense @raphinesse?

[janpio]

Currently working on splitting the tests in Win8.1 and Win10 batches, then using pending on them to get rid of the failures. Additionally I will add another build with explicit MSBUILDDIR set to C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin - so future changes on the discovery logic will pop up earlier.

[janpio]

Build is green :D