Coder Social home page Coder Social logo

Comments (13)

cels avatar cels commented on June 6, 2024 3

Anything new here? Is there a plan when this will be merged?

from cordova-plugin-network-information.

ZumelzuR avatar ZumelzuR commented on June 6, 2024 2

#130

from cordova-plugin-network-information.

breautek avatar breautek commented on June 6, 2024 2

@ZumelzuR Any plan for this code merge? or Are there any alternative to this?

He doesn't have write access to the repository, only Apache members can merge it in.

Looking at the PR it looks like it's marked as a breaking change, so it won't be merged in until we prepare the main branch as a major release. Right now it's prepared as a patch release.

Additionally it only has 1 approved review, and usually we like to see at least 2 approved reviews from Apache members. Others are also welcome to review/test the PR.

from cordova-plugin-network-information.

cels avatar cels commented on June 6, 2024 1

Is there anything new on this problem? The PR is open for almost a year 🤔

from cordova-plugin-network-information.

ZumelzuR avatar ZumelzuR commented on June 6, 2024 1

Sorry was impossible for me to do the fixes they required for the MR. I did it today so hope they approve :D

from cordova-plugin-network-information.

timbru31 avatar timbru31 commented on June 6, 2024

PR's welcome!

from cordova-plugin-network-information.

paulieo10 avatar paulieo10 commented on June 6, 2024

Has there been any progress with this issue? I'd say being able to detect 5g is quite important. Does anyone know how the plugin behaves a the moment when a device is connected to 5g? Will it return UNKNOWN?

from cordova-plugin-network-information.

ZumelzuR avatar ZumelzuR commented on June 6, 2024

Has there been any progress with this issue? I'd say being able to detect 5g is quite important. Does anyone know how the plugin behaves a the moment when a device is connected to 5g? Will it return UNKNOWN?

I will do a PR with the improvements for 5g. I already tested with android but I still some time for ios.

from cordova-plugin-network-information.

cels avatar cels commented on June 6, 2024

Thanks a lot!

from cordova-plugin-network-information.

mdivya-symplr avatar mdivya-symplr commented on June 6, 2024

@ZumelzuR Any plan for this code merge? or Are there any alternative to this?

from cordova-plugin-network-information.

ZumelzuR avatar ZumelzuR commented on June 6, 2024

I dont know how to fix the ios12 test fail, if someone can lead me on this I could try to fix what is missing to be approved. Anyway for the moment feel free to use my fork https://github.com/ZumelzuR/cordova-plugin-network-information

from cordova-plugin-network-information.

BigBalli avatar BigBalli commented on June 6, 2024

Happy to help but the logs for this run have expired and are no longer available.

from cordova-plugin-network-information.

ZumelzuR avatar ZumelzuR commented on June 6, 2024

Happy to help but the logs for this run have expired and are no longer available.

Same here, how we can run this again?

from cordova-plugin-network-information.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.