Coder Social home page Coder Social logo

Comments (5)

brodybits avatar brodybits commented on September 1, 2024 2

And I think a PR would be very welcome.

from cordova-fetch.

raphinesse avatar raphinesse commented on September 1, 2024 1

👍

I'd say this change requires a major release of cordova-fetch. Given that and the fact that --no-save is broken anyway, we could seize the opportunity and remove support for any user-provided options.

from cordova-fetch.

GedasGa avatar GedasGa commented on September 1, 2024 1

Yes, I did the changes that I have described. I believe that's all we need for saving platforms and plugins to the devDependencies.

However, I didn't remove the user-provided options as @raphinesse suggested, but I thought maybe that needs a further discussion and could be a separate PR.

from cordova-fetch.

GedasGa avatar GedasGa commented on September 1, 2024

👍

I'd say this change requires a major release of cordova-fetch. Given that and the fact that --no-save is broken anyway, we could seize the opportunity and remove support for any user-provided options.

Yes, I also think that's for the next major release of cordova-fetch. In that case, maybe it would be possible to get rid of the cordova-fetch altogether. Anyway, I'll create a draft PR on the changes, I've implied.

from cordova-fetch.

brodybits avatar brodybits commented on September 1, 2024

Thanks @GedasGa for your efforts. Getting rid of cordova-fetch sounds like a more drastic overhaul, would be nice if this could give us some performance benefits. I personally would not mind a gradual approach. PR #65 seems to be ready for review, not sure if that was your intention or not.

from cordova-fetch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.