Comments (5)
And I think a PR would be very welcome.
from cordova-fetch.
👍
I'd say this change requires a major release of cordova-fetch
. Given that and the fact that --no-save
is broken anyway, we could seize the opportunity and remove support for any user-provided options.
from cordova-fetch.
Yes, I did the changes that I have described. I believe that's all we need for saving platforms and plugins to the devDependencies.
However, I didn't remove the user-provided options as @raphinesse suggested, but I thought maybe that needs a further discussion and could be a separate PR.
from cordova-fetch.
👍
I'd say this change requires a major release of
cordova-fetch
. Given that and the fact that--no-save
is broken anyway, we could seize the opportunity and remove support for any user-provided options.
Yes, I also think that's for the next major release of cordova-fetch
. In that case, maybe it would be possible to get rid of the cordova-fetch
altogether. Anyway, I'll create a draft PR on the changes, I've implied.
from cordova-fetch.
Thanks @GedasGa for your efforts. Getting rid of cordova-fetch
sounds like a more drastic overhaul, would be nice if this could give us some performance benefits. I personally would not mind a gradual approach. PR #65 seems to be ready for review, not sure if that was your intention or not.
from cordova-fetch.
Related Issues (20)
- cordova cannot add plugins from git (CordovaError: Error: An unknown git error occurred) HOT 15
- coho audit-license-headers issues in cordova-fetch HOT 4
- cordova-fetch patch release August 2018 HOT 1
- Incorrect module ID in case of certain URL patterns HOT 3
- Support node recursive module resolution algorithm HOT 2
- Detect which package manager to invoke HOT 5
- How to handle `save: true` when requested package is already installed HOT 5
- cordova-fetch is much slower at prepare HOT 26
- Private repository and UNMET DEPENDENCY HOT 3
- Install a cordova plugin by tagged version from a custom git repo fails HOT 2
- Adding Cordova plugins is much slower HOT 1
- Too slow donwloading/installing plugins HOT 1
- Fails to get the installed target package name HOT 1
- cordova-fetch cannot install plugins from git repos with npm 3 if project has unmet peer dependencies HOT 9
- CordovaError: Could not determine package name from output HOT 9
- Cannot determine package name from spec git+https://github.com... HOT 10
- [email protected] -> [email protected] breaks plugin installs using git repos or local directories HOT 10
- cordova-android referencing git repo is changed to npm package version when performing a release build HOT 7
- cordova prepare : failed to fetch plugins with github spec with npm@7 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cordova-fetch.