Coder Social home page Coder Social logo

Comments (11)

quinnj avatar quinnj commented on September 2, 2024

It's helpful to post backtraces as that can often quickly show where the error is

from arrow-julia.

xiaodaigh avatar xiaodaigh commented on September 2, 2024

It prints out alot of stuff. It's like 11pm. I will try to get a MWE together.

from arrow-julia.

quinnj avatar quinnj commented on September 2, 2024

Alright, so the error here is because it doesn't know how to map Symbol or Char columns to arrow format. I guess in both cases, we should just map them to strings.

from arrow-julia.

quinnj avatar quinnj commented on September 2, 2024

I guess the biggest question is if we're ok not having round-tripping in these cases; i.e. we could allow writing columns of Symbol/Char, but they'll be read back in as strings. @bkamins @nalimilan , any thoughts/preferences here?

from arrow-julia.

nalimilan avatar nalimilan commented on September 2, 2024

Not sure. Maybe see what Feather.jl does? Also of interest is what RCall should do with CategoricalArray{T} when !(T<:AbstractString), as R only supports string factors (JuliaInterop/RCall.jl#331).

from arrow-julia.

bkamins avatar bkamins commented on September 2, 2024

I think the priority is to allow saving things with as little problems as possible. Symbol and Char are normal in Julia.

Given your comment I understand that we have a choice:

  1. either error on them
  2. or convert to String when saving

I would prefer the option 2. maybe with a @warn about conversion

from arrow-julia.

quinnj avatar quinnj commented on September 2, 2024

I mean, Feather.jl will just be a wrapper around Arrow.jl pretty soon, so they'll do whatever we do. I also think I like the idea of option 2 w/ a warning. I think people should understand that Arrow.jl isn't meant to be a serialization package, even though it can handle a wide range of types of objects. But even still, I think doing some automatic conversions will be convenient.

from arrow-julia.

bkamins avatar bkamins commented on September 2, 2024

Agreed

from arrow-julia.

xiaodaigh avatar xiaodaigh commented on September 2, 2024

There is a way to store arbitrary metadata right? We should remember them as Julia:Symbol and Julia:Char types. So in Python and r, they get read as String but in Julia we can use the metadata to restore them as Symbol and Char?

from arrow-julia.

quinnj avatar quinnj commented on September 2, 2024

Ah, I forgot about that; yes, that's a pretty good idea. I'll have to see how we can work the plumbing in for that.

from arrow-julia.

quinnj avatar quinnj commented on September 2, 2024

Ok, took a bit of work, but I think I've got it all working for Symbol/Char. #11

from arrow-julia.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.