Coder Social home page Coder Social logo

Comments (11)

shinhanbyeol avatar shinhanbyeol commented on August 24, 2024

This could be the cause of the build-documentation.yml or web-deploy.yml settings.
I think it'd be good to review this part together

from age-website.

JoshInnis avatar JoshInnis commented on August 24, 2024

@pdpotter @shinhanbyeol There are multiple branches that are told to with

publish:
  whoami: asf-site

in the .asf.yaml, could that be the issue

from age-website.

pdpotter avatar pdpotter commented on August 24, 2024

@pdpotter @shinhanbyeol There are multiple branches that are told to with

publish:
  whoami: asf-site

in the .asf.yaml, could that be the issue

That shouldn't be the issue. From https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features: The configuration file is specific to the branch in which it resides and only code blocks with a whoami matching the branch name will run. This does mean that the whoami section in the .asf.yaml file in the new-site branch doesn't really doe anything and can be removed I think.

from age-website.

pdpotter avatar pdpotter commented on August 24, 2024

@jbiz805 can you point me to the commits related to the changes that aren't applied on the website? I can't seem to find them. The typo fixed in 2874192 seems to be correctly fixed on the website (at the bottom of https://age.apache.org/joinus).

from age-website.

jbiz805 avatar jbiz805 commented on August 24, 2024

@pdpotter oh, i actually requested to @shinhanbyeol separately via chat, not through github. That's why commits related to the changes aren't here.

from age-website.

jbiz805 avatar jbiz805 commented on August 24, 2024

@pdpotter seems to be fixed now.
@shinhanbyeol did you fix it?

from age-website.

shinhanbyeol avatar shinhanbyeol commented on August 24, 2024

@pdpotter seems to be fixed now. @shinhanbyeol did you fix it?

No, I couldn't fix it.
I just did the restoration of the website

If deployment occurs in the master branch, the same thing will happen again.

from age-website.

jbiz805 avatar jbiz805 commented on August 24, 2024

@pdpotter seems to be fixed now. @shinhanbyeol did you fix it?

No, I couldn't fix it. I just did the restoration of the website

If deployment occurs in the master branch, the same thing will happen again.

@pdpotter Are there ways to avoid this from happening every deployment?

from age-website.

pdpotter avatar pdpotter commented on August 24, 2024

I don't quite understand how a commit on the master branch, triggering the Build documentation action, affects changes on the website to be rolled back. The last two deploys after a commit on the master branch (39f4ad4 and 562fe1d) only make changes to the age-manual directory in the asf-site branch. This asf-site branch contains the html files (and css an js) that are used for the website.

I did detect a rollbacks when changes in the new-site branch are made, as in the triggered build gatsby action, all files and directories in the asf-site branch are overridden. The build gatsby action does not build other versions of the documentation than master (e.g., v0.6.0). #90 should solve this issue.

In the future, the age-dev-manual folder that would be created by the Build documentation action in the developer-manual branch would be overridden as well, so an additional build step should be added to the workflow to rebuild this documentation as well. @JoshInnis did you remove the action in the developer-manual branch (390e6d3) because it rolled back changes in the website?

It would be easier and faster if the build gatsby action triggered by the new-site branch wouldn't overwrite the age-manual and age-dev-manual folders, but I haven't found a way to do this.

from age-website.

shinhanbyeol avatar shinhanbyeol commented on August 24, 2024

It could be an inefficient idea,

Why don't you add the process of building web-site resources to GitHub workflows on the master branch? https://github.com/apache/age-website/blob/new-web/.github/workflows/web-deploy.yml (see )

We don't know the cause of the problem at the moment, so I think we can solve the problem if we deal with it this way.
If you agree with @pdpotter, can I modify the build-document.yml file?

In addition, to say

The isuue of #90 is.
See build-documentation.yml and run the same command as spinx-multiversion docs build/html.
I am still having a hard time because the v0.6.0 version of the document has not been made.

https://github.com/apache/age-website/blob/new-web/.github/web-deploy.yml
Could you check the link above and review the code?

from age-website.

pdpotter avatar pdpotter commented on August 24, 2024

Why don't you add the process of building web-site resources to GitHub workflows on the master branch? https://github.com/apache/age-website/blob/new-web/.github/workflows/web-deploy.yml (see )

We don't know the cause of the problem at the moment, so I think we can solve the problem if we deal with it this way. If you agree with @pdpotter, can I modify the build-document.yml file?

I created a pull request that should do this: #98. Can you please review?

The isuue of #90 is. See build-documentation.yml and run the same command as spinx-multiversion docs build/html. I am still having a hard time because the v0.6.0 version of the document has not been made.

https://github.com/apache/age-website/blob/new-web/.github/web-deploy.yml Could you check the link above and review the code?

The link you provided doesn't seem to exist (I get a 404).
The v0.6.0 version of the document is not made because the v0.6.0 branch is not fetched when running web-deploy.yml. PR #90 fixes this by fetching all branches before spinx-multiversion docs build/html is run (see e962734).

from age-website.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.