Button rework .. about bootplus

[aozora]

That was ...by design... analyzing G+ styles, original G+ buttons have a minimum width that, in addition of a left & right padding, render the buttons wide even with single icons...
In order to avoi dfurther issues, I'll remove this limit...
I'll fix icon vertical alignment too, please be patient

[mafar]

** Fix button class **
buttons that are created like <a class="btn">sad</a> in bootstrap or like below need to be fixed.
<span class="btn"> <i class="icon-plus icon-white"></i> <span>Add files...</span> </span>
Many of bootstrap addons from bootsnip like datepicker, jquery file upload and many others are showing bad buttons.

[aozora]

I know, I'm working on it.. otherwise this issue wuold be already closed ;)

[mafar]

I was making a mistake by adding fontaweosme like
@import url('bootplus/css/bootplus.css'); @import url('bootplus/css/bootplus-responsive.min.css'); @import url('font-awesome/css/font-awesome.css');

Can you remove fontawesome from main bootplus.css ? so others dont have confusion ?
Did u make any changes to standard fontawesome ?

Now it has come down to this after removing additional fontawesome.

bootstrap-wysihtml5 plugin

bootstrap-timepicker bootstrap-datepicker jQuery-File-Upload 

<span class="btn btn-small"> <i class="icon-upload icon-white"></i> <span>Start upload</span> </span> <button class="btn btn-small"> <i class="icon-upload icon-white"></i> <span>Start upload</span> </button>
Above code produces different size buttons which is not right

[aozora]

I'm working on the fix for buttons...
About not including font-awesome in bootplus, I'll think about it. As of now there is only 1 icon that is used by the theme, the caret one (the down arrow used for dropdowns).

[aozora]

Just committed on master, please can you check it?
(font-aweseme is still included... for now)

[mafar]

Ok checking it.
I am asking to leave font-awesome as separate addon instead of merging it together with bootstrap css as it will surely cause confusion and people may end up adding duplicate fontawesome in header like me.

[mafar]

Problem is still there. Let me stup a jsfiddle with bootstrap addons which will help you review your changes.

[mafar]

I setup a jsfiddle http://jsfiddle.net/bababalcksheep/MgcDU/5006/ with datepicker addon,
http://jsfiddle.net/bababalcksheep/MgcDU/5006/show to see full screen view.

I could not use latest css from github at jsfiddle to i used css from http://aozora.github.io/ .
Fontawesome is not showing icon for now. May be we can add popular bootstrap addons there and check for css design problems.

[aozora]

I committed new updates. And now Font-Awesome is no more bundled.

For the datepicker, the problem is in datepicker.css; add this fix in your css:
/* FIX FOR datepicker.css */
.input-append.date .add-on i, .input-prepend.date .add-on i {
display: inline-block;
}

For the datepicker, I suggest you to use the improved version you can find here: https://github.com/eternicode/bootstrap-datepicker