Comments (8)
would you mind posting a full example of code I should add to avifpng.c?
Try replacing the content of your avifpng.c
file by this.
from libavif.
would you mind posting a full example of code I should add to avifpng.c?
Try replacing the content of your
avifpng.c
file by this.
wow! thanks a lot! it works!
from libavif.
Ah, good ol' -Werror=clobbered
. My favorite!
This should fix it:
I'm going to be adding some new code this week and likely bumping the version afterwards, so if you don't like building from master, expect a proper version tag with this fix in the next couple of days.
from libavif.
Similar favorite one here:
../apps/shared/avifpng.c: In function ‘avifPNGWrite’:
../apps/shared/avifpng.c:143:14: error: variable ‘writeResult’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered]
143 | avifBool writeResult = AVIF_FALSE;
| ^~~~~~~~~~~
cc1: all warnings being treated as errors
from libavif.
Fixed.
from libavif.
Similar favorite one here:
../apps/shared/avifpng.c: In function ‘avifPNGWrite’: ../apps/shared/avifpng.c:143:14: error: variable ‘writeResult’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered] 143 | avifBool writeResult = AVIF_FALSE; | ^~~~~~~~~~~ cc1: all warnings being treated as errors
almost same here, fix please ;)
FAILED: CMakeFiles/avif_apps.dir/apps/shared/avifpng.c.o
/usr/bin/cc -I../include -O2 -DNDEBUG -Wall -Wextra -Werror -pthread -std=gnu99 -MD -MT CMakeFiles/avif_apps.dir/apps/shared/avifpng.c.o -MF CMakeFiles/avif_apps.dir/apps/shared/avifpng.c.o.d -o CMakeFiles/avif_apps.dir/apps/shared/avifpng.c.o -c ../apps/shared/avifpng.c
../apps/shared/avifpng.c: In function ‘avifPNGWrite’:
../apps/shared/avifpng.c:393:14: error: variable ‘monochrome8bit’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered]
avifBool monochrome8bit = (avif->yuvFormat == AVIF_PIXEL_FORMAT_YUV400) && !avif->alphaPlane && (avif->depth == 8) &&
^
../apps/shared/avifpng.c:396:9: error: variable ‘colorType’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered]
int colorType;
^
cc1: all warnings being treated as errors
from libavif.
almost same here, fix please ;)
Is #1151 enough?
from libavif.
almost same here, fix please ;)
Is #1151 enough?
Thanks! I'd like to believe that it is, but I have no idea how to deal with C language :) so would you mind posting a full example of code I should add to avifpng.c?
from libavif.
Related Issues (20)
- MSVC: avifsampletransformtest.cc(153): warning C4244: 'argument': conversion from 'const avifSampleTransformTokenType' to 'uint8_t', possible loss of data
- Seemingly uncommon use of $<BUILD_INTERFACE> generator expressions in target_compile_options() HOT 2
- In a shared library build, avifincrtest is linked with both the libavif shared and static libraries. HOT 1
- Windows linker error LNK2019: unresolved external symbol __imp_avifGainMapMetadataDoubleToFractions referenced in function avifJPEGParseGainMapXMPProperties HOT 3
- In libavif v1.1.0, only the source files in the avif_obj and avif_apps_obj OBJECT libraries are compiled with warnings enabled HOT 1
- Consider setting the CMAKE_MSVC_RUNTIME_LIBRARY variable to use /MD in all build configurations on Windows
- Investigate whether we still need to compile with /source-charset:utf-8 /execution-charset:us-ascii on Windows HOT 5
- Consider using the MSVC linker option /WX if the AVIF_ENABLE_WERROR cmake option is ON HOT 1
- Consider enabling compiler warnings in add_avif_fuzztest() in tests/CMakeLists.txt HOT 3
- Consider testing __STDC_VERSION__ >= 202000L in avif.h for C compiler's [[nodiscard]] support HOT 1
- Audit and fix integer overflows in multiplications with rowBytes in src/reformat.c
- gtest/avif_fuzztest_helpers.cc is compiled once for each fuzztest target
- Fix the limitation of recent-cmake in the setup-common GitHub action HOT 1
- CMAKE_CXX_FLAGS_RELEASE is empty if -DAVIF_CODEC_AOM=LOCAL -DAVIF_LIBYUV=OFF is specified HOT 8
- Check version numbers of boxes related to the ISO gain map experimental feature HOT 17
- Feature request: separate out encoding of chroma & alpha HOT 4
- Add/handle 'tmap' brand HOT 1
- android jni compile HOT 4
- supported_gainmap_writer_version_with_extra_bytes.avif is invalid HOT 6
- Implement the HDR parts of SlimHEIF
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libavif.