Warnings in avifjpeg.c about libavif

[y-guyon]

would you mind posting a full example of code I should add to avifpng.c?

Try replacing the content of your avifpng.c file by this.

[marchLex]

would you mind posting a full example of code I should add to avifpng.c?

Try replacing the content of your avifpng.c file by this.

wow! thanks a lot! it works!

[joedrago]

Ah, good ol' -Werror=clobbered. My favorite!

This should fix it:

b76d06f

I'm going to be adding some new code this week and likely bumping the version afterwards, so if you don't like building from master, expect a proper version tag with this fix in the next couple of days.

[novomesk]

Similar favorite one here:

../apps/shared/avifpng.c: In function ‘avifPNGWrite’:
../apps/shared/avifpng.c:143:14: error: variable ‘writeResult’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered]
  143 |     avifBool writeResult = AVIF_FALSE;
      |              ^~~~~~~~~~~
cc1: all warnings being treated as errors

[joedrago]

Fixed.

0e9a4b4

[marchLex]

Similar favorite one here:

../apps/shared/avifpng.c: In function ‘avifPNGWrite’:
../apps/shared/avifpng.c:143:14: error: variable ‘writeResult’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered]
  143 |     avifBool writeResult = AVIF_FALSE;
      |              ^~~~~~~~~~~
cc1: all warnings being treated as errors

almost same here, fix please ;)

FAILED: CMakeFiles/avif_apps.dir/apps/shared/avifpng.c.o
/usr/bin/cc  -I../include -O2 -DNDEBUG   -Wall -Wextra -Werror -pthread -std=gnu99 -MD -MT CMakeFiles/avif_apps.dir/apps/shared/avifpng.c.o -MF CMakeFiles/avif_apps.dir/apps/shared/avifpng.c.o.d -o CMakeFiles/avif_apps.dir/apps/shared/avifpng.c.o   -c ../apps/shared/avifpng.c
../apps/shared/avifpng.c: In function ‘avifPNGWrite’:
../apps/shared/avifpng.c:393:14: error: variable ‘monochrome8bit’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered]
     avifBool monochrome8bit = (avif->yuvFormat == AVIF_PIXEL_FORMAT_YUV400) && !avif->alphaPlane && (avif->depth == 8) &&
              ^
../apps/shared/avifpng.c:396:9: error: variable ‘colorType’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered]
     int colorType;
         ^
cc1: all warnings being treated as errors

[y-guyon]

almost same here, fix please ;)

Is #1151 enough?

[marchLex]

almost same here, fix please ;)

Is #1151 enough?

Thanks! I'd like to believe that it is, but I have no idea how to deal with C language :) so would you mind posting a full example of code I should add to avifpng.c?