Coder Social home page Coder Social logo

Comments (3)

joedrago avatar joedrago commented on July 20, 2024

Yeah, I think it is just a habit from an antiquated notion that C might return all bits set on a comparison instead of just 1 on some compilers, which would cause somebody checking against AVIF_TRUE to fail, but in practice nobody really does that anyway, so I agree with you.

I will remove them before I make my next release.

from libavif.

wantehchang avatar wantehchang commented on July 20, 2024

Thank you for the quick fix!

Some code uses an if statement for the conversion. Here is an example in src/codec_dav1d.c:

static avifBool dav1dCodecAlphaLimitedRange(avifCodec * codec)
{
if (codec->decodeInput->alpha && codec->internal->hasPicture && (codec->internal->colorRange == AVIF_RANGE_LIMITED)) {
return AVIF_TRUE;
}
return AVIF_FALSE;
}

It's not easy to find such code with grep.

from libavif.

joedrago avatar joedrago commented on July 20, 2024

That function doesn't exist anymore. I killed it today.

from libavif.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.