Comments (5)
This issue is similar to #379, but while that one was just a matter of lacking documentation, this one is a real bug.
from orval.
The problem seems to be that the library assumes that if the mutator is overridden, it doesn't use Axios
, therefore it doesn't add the arguments or the imports:
Here:
orval/packages/swr/src/index.ts
Lines 695 to 696 in 15e9033
And here (my use case uses split-tags, so that's how I got here):
Maybe in more places too. One possible solution would be to add a isAxios
option to the override.mutator
attribute:
module.exports = {
test: {
output: {
....
client: 'swr',
override: {
mutator: {
path: './custom-instance.ts',
name: 'customInstance',
isAxios: true // 👈 This is a fix, not sure if it's acceptable
},
...
},
},
}
}
Then we could (pseudo code):
const swrMutationFetcherOptions =
(!mutator || (mutator && override?.mutator?.isAxios)) && isRequestOptions ? 'options?: AxiosRequestConfig' : '';
hasGlobalMutator: !!output.override.mutator && !output.override.mutator.isAxios,
from orval.
I’ve encountered the same issue, and for now, I’ve downgraded to version 6.23.0.
from orval.
Thank you for made this report.
I understood that when using a custom instance of Axios
, the settings of Axios
cannot be passed to the custom instance via hooks
.
I think a good solution is to specify a custom instance using Axios
via the orvrride property and i prefer to use isAxios: true
over clinet: 'axios'
because the custom instance may have additional clients in the future.
You can submit a PR and I'll submit in turn.
from orval.
Is this the same as #959 ???
from orval.
Related Issues (20)
- Query options for an operation have no effect
- RangeError when generating mocks HOT 1
- NonReadonly type incorrectly includes readonly fields HOT 4
- Prettier: true fails for zod when not generating a schema
- Unstable return reference of generated hook when using a custom mutator hook.
- Zod: unstable/breaking variable names for validation lengths HOT 7
- Type Issue: RegEx is not accepted in `defineConfig.[name].input.filters.tags` HOT 1
- Feature request: support different enum key
- Question: Limitations of client instance customisation
- Add support to nested `useInfiniteQueryParam`
- Non-reactive query params in Vue when using useInfiniteQueryParam HOT 2
- Zod: only generates 200 response bodies HOT 9
- Types in generated react-query schema have unstable order, causing noisy diffs HOT 1
- [Feature] Add ability to pass custom types for a string given a format hint
- Strange enum generation while using anyOf in schema HOT 2
- support `fetch` client HOT 3
- MSW: overrideResponse should allow async functions
- Non-requred requestBody results in TS error
- Faker types are incompatible with contract definition for number enums
- [Feature]Enable `faker.helpers.fromRegExp()` to be applied to msw mock from pattern keyword
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from orval.