Comments (12)
@icy-meteor onOpen
is the default return of Chakra's useDisclosure
. and right, it's a callback that gets fired when something gets opened. But the verb open is just like a variable name, so we say, open the list, when the variable open is true.
Besides, changing this will be a breaking change.
And you can close this if it's working well for you.
from choc-autocomplete.
Could you reproduce this in codesandbox please?
from choc-autocomplete.
Give me some time, I'll get back to you with the link.
from choc-autocomplete.
https://codesandbox.io/s/choc-ui-autocomplete-input-right-element-flp5b?file=/src/App.tsx
I have replaced the icon with some text for now but it's pretty much the same behaviour. Clicking the doesn't do anything.
from choc-autocomplete.
Hi @icy-meteor You don't have any onClick handler on the inputrightelement. What're you expecting it to do onClick.
from choc-autocomplete.
I want it to open the dropdown.
from choc-autocomplete.
Then you have to set an Onclick handler for that
from choc-autocomplete.
Check this out. onOpen
and onClose
are also exposed as internal state. @icy-meteor
from choc-autocomplete.
Yes, I saw this. I couldn't find what is the method exposed to open and close the popup. Neither were there any examples other than isOpen.
Is it onOpen and onClose? That doesn't sound right though.
from choc-autocomplete.
Yeah it's onOpen
and onClose
from choc-autocomplete.
Okay, maybe we might want to fix the naming convention :)
onOpen sounds more like a callback that gets fired when something is open. Doesn't sound like something that will trigger an open behaviour.
Thanks for the response. I'll try this out.
from choc-autocomplete.
LGTM. Thanks.
from choc-autocomplete.
Related Issues (20)
- Bad css in dark color mode and variant `filled` with Next.js. HOT 4
- AutoCompleteList popover placement isn't 'auto' HOT 1
- defaultValue with Array of Number doesn't work
- Label returning value
- Can't install library due to framer-motion issue HOT 2
- no option HOT 1
- *multiple* - Cannot read properties of undefined (reading '_focus') HOT 1
- submitKeys prop is incorrectly described in README
- [Dev environment] Local repository install in a real project HOT 3
- Issue with updating styles of AutocompleteList component
- deletion of input does not make full list reappear HOT 2
- Can't resolve '@choc-ui/chakra-autocomplete' HOT 3
- Multiple invalid attribute name errors
- set "value" props doesn't change input value HOT 2
- Update package.json for types declaration ? HOT 1
- sslint: cannot find module umd.js HOT 5
- Why has react-nanny become a peer-dependency? HOT 1
- Contribution instructions should use npm HOT 1
- Reset items after submission HOT 5
- tabbing out of autocomplete input selects the focused item in multiple mode HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from choc-autocomplete.