Comments (5)
Hi @avinassh Awesome that you have built an OS X version. I don't know if you can send me PR if you haven't forked my repository.
Also I saw your code, it is a standalone OS X version. Can you integrate the code with my code? So that it runs the same on all the version? You will need to add checks using the os that the user is using before running the script. I think it can be done using os.name or platform.platform() or platform.system() or sys.platform.
Go ahead fork my repo, switch to a new branch, hack you way ahead, and then send me a PR. Thanks a lot.
from scorer.py.
Yes, I haven't forked your project and started separately. Reason is, for OS X instructions are bit different and requires extra installation of libraries outside pip
. First user needs to install brew
and terminal-notifier
, these are outside pip
. Readme instructions will become cumbersome and confusing. I also saw this latest issue #2, I don't see any such restrictions in OS X. Plus I don't have linux installed and can't run tests. Thats why I thought a separate project will be nice. So may be we can mention in Readme about OS X version and development can be independent.
What do you say?
from scorer.py.
Ah, sure. Why not. Do send me a PR with a link to your script in README.md.
But just as a suggestion, I would like to research a bit on how to make a script cross platform?
I have seen the same scripts running on both Linux/unix as well as OSX. I don't have a mac with me, so I can't even test it. Would be great to have someone with a mac in the team :)
But for the time being, please send me a PR with a modification in the README.md so that I can merge it right away.
Cheers
from scorer.py.
Sure, sending a PR now.
Even I am interested to know how to make script cross platform, will do bit of research. Thanks!
from scorer.py.
You can use the platform module. Check it out.
from scorer.py.
Related Issues (20)
- suggestion to use proxy and also to specify fetch frequency HOT 3
- requests.exceptions.ConnectionError HOT 4
- Lot of hardcoding in the current version HOT 3
- No JSON objects could be decoded HOT 8
- ImportError after recent changes to app.py HOT 2
- Need more wiki for this project.
- Need more documentation for the code
- Add a way to pass command line arguments to scorer HOT 14
- Need help with setuptools: HOT 9
- Code breaks when there is no notification daemon working. HOT 2
- Addition of a config file to store default options? HOT 2
- Pynotify not in install requires
- Integrate `pytest` for test cases. HOT 1
- Migrate to pipenv
- Remove dependency on `pynotify` HOT 1
- Refactor code into API
- Exception Catching While Python not able to reach the URL for reading the live matches HOT 3
- logging changes
- Remove the hard coded values and add the config file for making the code manageable
- TypeError: unsupported operand type(s) for +: 'NoneType' and 'str' HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scorer.py.