Comments (12)
Can you have a look at it running inside Firejail? All AppImages must pass running a test inside Firejail in order to be listed on https://appimage.github.io/. Thanks.
firejail --quiet --noprofile --net=none --appimage ./Your.AppImage
from blue-glow.
Then I think that the program argument should have pointed the executable itself and so the updater tries to update and show invalid AppImage since it is a normal ELF executable. I think I should change this behavior. Also I did try running it without --net=none
which yields the same results.
from blue-glow.
Maybe just change the order, first check for $APPIMAGE
and only if that fails (it should never) look at argv[0]
?
from blue-glow.
This is how we run AppImages inside Firejail:
from blue-glow.
How is the ""
determined? By looking at the $APPIMAGE
environment variable? Possibly it doesn't work this way (yet) when run inside Firejail. If so, we may want to request exporting $APPIMAGE
, $APPDIR
, and $OWD
in the FIrejail project.
from blue-glow.
How is the "" determined? By looking at the $APPIMAGE environment variable?
First we use the program arguments to determine the AppImage path(if the the program arguments contains an executable then it runs the updater and does not look inside the environmental variable) , if that fails then we go for $APPIMAGE environmental variable , if that also fails then we fail.
from blue-glow.
I think the updater cannot get the AppImage path from the program arguments and the environmental variable. If firejail could just pass the original program arguments along with its working directory then the updater should work under firejail. It seems to be impossible to do a update inside a sandbox. Since the update modifies the file in the host system , The sandbox is preventing it. ( I don't think they would change this feature)
from blue-glow.
You should re-run this after the current build is finished and deployed.
from blue-glow.
With the configuration I posted above, the application is not even allowed to access the network, so the intended behavior is that the application should say "Could not check for updates, please check your internet connectivity" or something like that.
If you run without --net=none
then it can access the network and should be able to check whether a new version is available.
from blue-glow.
Actually Firejail does export $APPIMAGE
:
from blue-glow.
Maybe just change the order, first check for $APPIMAGE and only if that fails (it should never) look at argv[0]?
Yes , that seems to fix it. The latest build should run under firejail.
from blue-glow.
Thank you, it passed the test. 👍
from blue-glow.
Related Issues (4)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from blue-glow.