Comments (4)
The package does not support tree shaking, that we should make such a drastic change? At the end of the day, bundled javascript by any and maintained bundler should three shake dead code.
from beautiful-react-hooks.
The package does not support tree shaking, that we should make such a drastic change? At the end of the day, bundled javascript by any and maintained bundler should three shake dead code.
I understand your point and yes, I think you're correct assuming that 99% of the times one is using this library they're definitely using React which probably means they're using webpack or rollup or vite or anything of that sort...
on the other hand, three-sharking is not an automatic feature, it has to be configured and therefore can be mis-configured by the user.
I wonder if it's our duty to "force" the user to write "good code" by imposing default exports...
I don't have an answer to be honest :))
from beautiful-react-hooks.
So I think if it's a 99% of the user's bundlers coverage + to be honest it's a breaking change and I'm not sure if necessary and worth change.
from beautiful-react-hooks.
So I think if it's a 99% of the user's bundlers coverage + to be honest it's a breaking change and I'm not sure if necessary and worth change.
fair enough... I'll do some research so I can possibly propose the right solution.
I'm closing this issue for now then
from beautiful-react-hooks.
Related Issues (20)
- Autogenerate CHANGELOG.md
- Feature request for useSSR hook HOT 2
- useThrottledCallback doesn't consider dependencies
- Update `react-router-dom` to v6 HOT 3
- I need help about writing tests, element.scrollWidth always is 0 HOT 3
- useAudio hook can't change src when input new src HOT 2
- useLocalStorage causing infinite loops when setValue is a dependency in a useEffect HOT 2
- Remove or reduce unsupported API console warnings HOT 3
- More feature from thrid libs HOT 2
- Type declaration error with useInterval hook's clearInterval function HOT 10
- Deprecate all react-router-dom related hooks HOT 1
- `useGeolocation` not updating state in Firefox desktop
- useAudioControls returning new controls object everytime state is updated
- :memo useWillUnmount should called useUnmount HOT 2
- Type resolution for ESM modules is broken HOT 6
- useDebouncedCallback doesn't consider its dependencies HOT 2
- ESM modules import does not working HOT 1
- react-router peer dependency is being install HOT 1
- Proposal to Update React Peer Dependency to Allow Installation of Later Versions HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from beautiful-react-hooks.