Comments (8)
I have checked this property in dets.
It works as expected if we use insert_next instead of insert. The problem of using insert is that in case of trying to insert duplicates, it will move the duplicated operation to the tail of the list instead of leaving it where it was originally placed.
For instance, lets say we insert operations in the following order: op1 -> op3 -> op4 -> op2 for key floppy. A look up over floppy key will return [op1,op3,op4,op2]. But if we insert op3 again, by using the regular insert, the lookup would return [op1, op4, op2, op3] while using insert_new, the look up will still return [op1,op3,op4,op2] which the desired output.
I have changed all inserts by insert_new. Please keep this on mind.
I will close this issue
from antidote.
I was only half right!
I was right saying that by using insert, the order is not preserved when duplicate inserts. Nevertheless, I was wrong saying that insert_new solves the problem.
I have modify it once more. Now, before inserting, the logging_vnode first check whether the operation has been already log. In case it is already logged, it just ignores the operations and return success.
I am pretty sure it works properly now.
from antidote.
It would be super nice to write a QuickCheck property for this.
from antidote.
Can you just write a quick riak_test to assert this behavior is true so we can prevent against regressions? Then we will close this one out.
from antidote.
Actually, I think I cannot do it. The tricky part of this is when inserting duplicated operations. From the API there is no way to do that so I cannot generate a test. Plus, the API only allows us to get the object materialised, in order to further test this from riak_test, I would need to expose an operation that returns the list of operations without materialize.
Please correct me if I am wrong and give some hints on how to do it.
from antidote.
I was rethinking ad retesting this. The current implementation only ensures order per key and not per partition. Do we need it per partition? In that case I think we would need to modify the way we store thinks because in the way we do it now and using sets, I would say is not possible.
from antidote.
Probably fixed with the new log version.
from antidote.
Marking this finished, as it related to the older version of the logging virtual node.
from antidote.
Related Issues (20)
- The command 'make test' fails when performed locally
- Survey on globally distributed software engineering HOT 1
- Missing Spec Annotations
- Prune / Trim Log
- Prune or Trim Log HOT 1
- Violations of causal consistency found HOT 10
- What's the status of this project? HOT 3
- Problems with inter_dc when the first address in the list leads to connection timeout.
- Update prometheus collector
- Coverdata test file is not cleaned up
- Lint apps/antidote_crdt/test
- Release source code not found warnings for prometheus dependency
- Add test cases for multiple updates on the same key
- Syntax error in antidote/apps/antidote/rebar.lock
- Inter DC partitioning can disrupt replication HOT 1
- Document supported hardware architectures
- pn-counter can lose :ok'd increments in a no fault environment
- pn-counters are susceptible to partitioning
- Document upgrade and downgrade processes
- Last release 2 years old HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from antidote.