Not Challenged to Accept Terms of Service or Privacy Policy on Registration about ngx-auth-firebaseui

[DannyHalm]

I believe an overlay modal would be best choice as it emphasis the acceptance of terms and conditions. Cheers..

…

Sent from my iPhone

On 2 Feb 2019, at 22:48, Anthony Nahas ***@***.***> wrote: @bailejl I've just fixed this issue! You had 100% right! the signup middle to check privacy policy.. and so on.. was only linked with the guest button! Thanks for reporting again! @bailejl @DannyHalm what do you think about the process and design related to this topic ? Should I keep the checkboxes nested in a Material Dialog and the sign up buttons always enabled ? Or do you think that the checkboxes could be in a better place? below the material input ? the sign up and guest buttons disabled until the checkboxes are checked ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[AnthonyNahas]

Thanks for reporting @bailejl
I will inspect that bug bei writing some unit tests ... hopping to find the issue quickly!!!

[DannyHalm]

Hello again Anthony, the text-hint for phone number is misleading. I tried the Mobile regular number from your program into an online reg-editor and the only number matching is [phone] and other variation will be denied. I suggest you add an option where the user choose his countries suffix in terms of +49 and add any regular Phone number omitting the initial 0( as you know can be Done by regular expression). Best Regards ...Danny

…

Sent from my iPhone

On 31 Jan 2019, at 06:20, Anthony Nahas ***@***.***> wrote: Thanks for reporting @bailejl I will inspect that bug bei writing some unit tests ... hopping to find the issue quickly!!! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[AnthonyNahas]

@DannyHalm I will really appreciate a PR for that

[AnthonyNahas]

@bailejl what do you think about two checkboxes in the register card for both tosUrl and privacy policy url ? ... instead of the dialog ?

[bailejl]

@AnthonyNahas Yes, with links to tosUrl and privacy policy url. I think that would be perfect.

[DannyHalm]

Yes those would be great to add but the register button should be disabled unless they have clicked on them and accepted the conditions and terms. Cheers ...

…

Sent from my iPhone

On 2 Feb 2019, at 17:18, Joe Bailey ***@***.***> wrote: @AnthonyNahas Yes, with links to tosUrl and privacy policy url. I think that would be perfect. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[AnthonyNahas]

@bailejl I've just fixed this issue! You had 100% right! the signup middle to check privacy policy.. and so on.. was only linked with the guest button! Thanks for reporting again!

@bailejl @DannyHalm what do you think about the process and design related to this topic ?
Should I keep the checkboxes nested in a Material Dialog and the sign up buttons always enabled ? Or do you think that the checkboxes could be in a better place? below the material input ? the sign up and guest buttons disabled until the checkboxes are checked ?

[AnthonyNahas]

@bailejl @DannyHalm this has been fixed in v2.3.0! I would appreciate your feedback ❤️ Thank you

[semla]

I am only getting asked to approve if I choose guest on the demo. Not if I choose Google or Twitter.
Could it be it is the same problem again?

[jackie-d]

It seems to still be a problem for a regular signup, with parameters set, no overlay shows or mandatory check required.

tosUrl="/legal/tos" privacyPolicyUrl="/legal/privacy"

Please investigate.

[jackie-d]

Just look at the code of ngx-auth-firebaseui-register component, and the functionality is totally missing.

I think a solution may be to adapt the ngx-auth-firebaseui component to act as a register component.