Create GET Orders about allyinvest.py

[anthonymorast]

Excellent questions.

For your last question, I think the FIXML stuff should definitely be converted to a user-friendly format (this is done in the reverse in the order_common_stock method). I really would prefer ordinary developers to not have to care about FIX.

As for your first question, if I recall correctly, the API wrapper more or less just returns the raw JSON/XML that comes out of Ally. Since there will probably be some FIX parsing in this case, it wouldn't hurt to convert any of the formats to JSON (as I expect most people to ignore the XML formatting) and let the developer deal with the details.

One thing I was working on when I was more active with this project was the ally/request and ally/response classes. The idea here is that the API requests and responses are wrapped up in Python classes which are more user-friendly. For example

account holdings request:
https://github.com/anthonymorast/AllyInvest.py/blob/master/ally/requests/account_holdings.py

account holdings response:
https://github.com/anthonymorast/AllyInvest.py/blob/master/ally/responses/account_holdings.py

there is example usage in the examples/example.py file.

You might consider implementing an account orders response/request and wrapping your parsing into that (if you'd like to). Otherwise, I would just parse the FIX into JSON and return the JSON and if the API returns a False type for some reason, maybe just return empty JSON.

[wmorgansoftware]

OK, sounds good. I can do both implementations, as the legacy continues to exist, and now that I've converted to using your package (gotta love how flask_dance forces you to have a HTTP request making debugging quite annoying), I've been using the legacy.

I'm going to have to update URLs after all, as the URL that's there forces XML instead of allowing for JSON.

[anthonymorast]

Sounds good. Thanks for your feedback/contribution. I look forward to your PR.

[wmorgansoftware]

Tried to push a new branch up to the project, and the terminal response is that I don't have permission to do so. I know I can push on my own projects. Would it be OK to put up a new branch with these proposed changes?

[anthonymorast]

I think you have to submit a pull request. Do you have your own fork of the repository with your changes?

If so, from your fork you should be able to go to the Pull Request tab and click the New Pull Request button to submit one to the main branch of this project.

[anthonymorast]

If not, you should fork the repository, add your changes, and then submit the request.

[wmorgansoftware]

OK, should be up with #6 .

[anthonymorast]

Looks good. Thanks again for the contribution!