Json Default Value to Lists? about kotshi

[ansman]

I don’t really understand this issue, what you describe is already supported, in exactly the same way as in your example

[ademar111190]

Sorry I was not clear.
What I was trying to say is why do not add this feature to the library, in the same way as the library already does with the defaultString and others.
Currently, everyone needs to add this same code to its project, so it is the motivation.

[ansman]

I see your point, I need to think about this. One would probably want to name it JsonDefaultValueEmptyList and then we need to add the same for sets and maps.

[ademar111190]

Sure.
I think the class can be more similar to the others and receive a value.

[ansman]

Annotation values must be compile time constants so lists are no allowed, otherwise we could simply create a generic annotation that accepts default values for all types.

[ademar111190]

I got it.
Given the limitation, I would say the idea to have the empties list, set, map, etc is good.

[JakeWharton]

Do you want this for all lists or just individual ones? You can write a generic JsonAdapter for this which will handle all non-null lists automatically. And even if you only want some properties to have this behavior, you can define your own annotation and have the JsonAdapter look for it. There shouldn't be a need to add explicit support in Kotshi as Moshi has built-in support for enabling this behavior already.

…

On Mon, Apr 9, 2018, 12:36 PM Ademar Alves de Oliveira < ***@***.***> wrote: I got it. Given the limitation, I would say the idea to have the empties list, set, map, etc is good. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#80 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEEEfMHnGEBPGknrzkN1jVyK9N9D8eZks5tm7gvgaJpZM4TLWd0> .

[ansman]

@JakeWharton It wouldn't work doing it in Moshi if you want a default value when the key is absent from the json.

[JakeWharton]

It would provided you are delegating to the built-in adapters for primitive types which I think the library does automatically when a JsonQualifer annotation is present.

…

On Mon, Apr 9, 2018 at 4:50 PM Nicklas Ansman Giertz < ***@***.***> wrote: @JakeWharton <https://github.com/JakeWharton> It wouldn't work doing it in Moshi if you want a default value when the key is absent from the json. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#80 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEEETqf7caOjV1dzt3Z37QO4TKOWMWxks5tm8mSgaJpZM4TLWd0> .

[ansman]

If a key is absent from the Json the adapter for that field is never queried.

For example given this class:

public class Foo {
  public Bar bar;
}

and this json:

{}

the adapter for Bar would never be called.

[JakeWharton]

True.

…

On Mon, Apr 9, 2018 at 4:55 PM Nicklas Ansman Giertz < ***@***.***> wrote: If a key is absent from the Json moshi is never queried. For example given this class: public class Foo { public Bar bar; } and this json: {} the adapter for Bar would never be called. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#80 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEEEatvljEs5ccNrwMlj4cCPMht7iVfks5tm8qmgaJpZM4TLWd0> .

[ansman]

Closing this, it's no longer relevant when #108 is merged