Coder Social home page Coder Social logo

Comments (2)

JakeWharton avatar JakeWharton commented on May 30, 2024

I'm against this as I'd like to see Gson whither away in a slow death. It's blown its complexity and API budget for continued tolerance and historical baggage makes change nearly impossible.

However, this should be trivial as the Moshi APIs currently used by this project were modeled from the best parts of Gson.

I would think it'd go something like this:

  • Rename @JsonSerializable to something library-specific (prefix with Moshi or @MoshiJsonAdapter or @GenerateJsonAdapter or whatever).
  • Renamed @KotshiJsonAdapterFactory in a similar fashion.
  • Introduce Gson variants of those two annotations.
  • Refactor the processing steps to use an enum which contains various information like:
    • A ClassName for the adapter and factory.
    • A ClassName for the JsonReader and JsonWriter.
    • Strings for the various method names.

The generated logic is 99% shared and the enum provides the differently named bits depending on which annotation is present.

from kotshi.

ansman avatar ansman commented on May 30, 2024

I agree, I don't think it should be done too. I haven't had any requests for it so I think it could probably be skipped.

from kotshi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.