100 chars is too short for spec files about molecule

[retr0h]

Unfortunately, no matter what number we pick here, someone will not like it. RuboCop, has adopted the community driven Ruby Style Guide. However, I do not see anything specific to line length numbers in the spec.

Since these cops can be changed or disabled, feel free to submit a PR to ansible-sytem's .rubocop.yml with:

LineLength:
  Enabled: false

[retr0h]

Actually let me think this over. Rubocop, will probably only search for a .rubocop.yml from the current directory.

[retr0h]

I'm leaning towards having the user manually create a .rubocop.yml that meets their linting requirements vs molecule managing default rules.

So if you don't like the long lines, I suggest creating a .rubocop.yml with something like the following in the base of your role.

LineLength:
  Enabled: false

[sandinak]

I've done this to get the role working .. however i think that many people will have paths that will require this setting and this fix is a bit nebulous .. i'd recommend disabling it entirely as the constraint isn't useful to this application.

[retr0h]

I don't have a problem with this. I actually like this requirement. However, if people don't they can disable just as you did.

[dhutty]

Please add a note about this to the molecule docs – or even just a link to an existing discussion of .rubocop.yml. Perhaps we should have a Tips/Conveniences section (both for molecule directly and for the tools molecule uses: rubocop in this case, but also, serverspec/testinfra/vagrant/etc). Since the whole point of molecule is to reduce the barrier for testing Ansible roles as part of the development process, it’s at least partly an educational project as well as a tool project.

From: John Dewey [mailto:[email protected]]
Sent: Wednesday, November 18, 2015 8:40 PM
To: metacloud/molecule
Subject: Re: [molecule] 100 chars is too short for spec files (#2)

I'm leaning towards having the user manually create a .rubocop.yml that meets their requirements around linting vs us managing a default one.

So if you don't like the long lines, I suggest creating a .rubocop.yml with something like the following in the base of your role.

LineLength:

Enabled: false

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/2#issuecomment-157919888.