Coder Social home page Coder Social logo

Comments (3)

conorsch avatar conorsch commented on July 17, 2024

The trailing newline linting error in YAML files threw me for a loop when I started using molecule as well. My objection is the same, namely that it feels distinctly anti-POSIX, but having a style pragma enforced by tooling is arguably better than bickering about preferences.

To put myself in the maintainers' shoes, adding an option to permit trailing newlines, but continue linting on all other attributes, would open the door for a nightmare of configurability. You can, after all, excuse directories from the linting, which may be the best course of action for you if you don't want to trim your YAML files. For spec and other files, doesn't seem like we have much recourse at this time.

from molecule.

dhutty avatar dhutty commented on July 17, 2024

Molecule's validator is not checking for trailing newlines (that the last line matches /\n$/), it is checking for trailing blank lines, that is that the last line of the file should not be empty (matches /^\n$/). This is an important distinction.

https://github.com/metacloud/molecule/blob/master/molecule/validators.py#L96

from molecule.

conorsch avatar conorsch commented on July 17, 2024

it is checking for trailing blank lines

Thank you for clearing this up. Great explanation, and I now agree with the implementation.

from molecule.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.