Coder Social home page Coder Social logo

Comments (6)

guidograzioli avatar guidograzioli commented on August 15, 2024 1

Actually, I don't a reason for not placing the upgrade molecule upstream too

from keycloak.

guidograzioli avatar guidograzioli commented on August 15, 2024 1

Mate, the idea is to catch up feature-wise, and then keep up, with rhbk for the time being :)
Any feature you may be willing to share with the community will be joyfully received (and eventually moved downstream). Just please keep features separated in their PR stream, and hold breaking stuff for major releases

from keycloak.

guidograzioli avatar guidograzioli commented on August 15, 2024

Hello; I am actively on this (on the downstream tests for the rhbk collections which are not visible publicly , sorry)

from keycloak.

guidograzioli avatar guidograzioli commented on August 15, 2024

Fact is, ideally there shouldn't be anything in conf/ or providers/ which is not configured by the collection itself; themes is a different beast. I am not sure how to handle the case of "manually" added content.
The upgrade should take care of round-robin restarts, via systemd wait_for facility.

from keycloak.

hwo-wd avatar hwo-wd commented on August 15, 2024

Fact is, ideally there shouldn't be anything in conf/ or providers/ which is not configured by the collection itself; themes is a different beast. I am not sure how to handle the case of "manually" added content. The upgrade should take care of round-robin restarts, via systemd wait_for facility.

Thinking about it, you are actually right; it's just that the role is missing the possibilities to add policies (black/white lists); moreover, the ability to download providers (the functionality you've recently added via keycloak_quarkus_providers) would have to be extended to support maven downloads (be it from maven central or private maven github repos).
Using the same paradigm we could also tackle themes since at the end of the day they are just jar files deployed similarly to SPIs.
My playbook includes quite a lot of this functionality I could upstream if you're willing to integrate these things into the role? (and you're not worried with over-engineering the role, that is ;-))

from keycloak.

hwo-wd avatar hwo-wd commented on August 15, 2024

Closing in favor of #229, #226, #222.

It's only really the /themes directory left:

rhbk-24.0.3# cat themes/README.md
Creating Themes

Themes are used to configure the look and feel of login pages and the account management console.

Custom themes packaged in a JAR file should be deployed to the ${kc.home.dir}/providers directory. After that, run
the build command to install them before starting the server.

You are also able to create your custom themes in this directory, directly. Themes within this directory do not require
the build command to be installed.

But to be honest, from a production point of view the whole thing should be put in providers.

from keycloak.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.