Coder Social home page Coder Social logo

Comments (1)

briantist avatar briantist commented on July 22, 2024

Hi @erikgb welcome to the new collection!

Oof that's unfortunate. This is another area where JWT seems to have non-standard behavior compared to other auth methods in hvac. I've opened an issue for this one too: hvac/hvac#655

I think you're right about the fix being easy.

For testing, I hope it wouldn't be too difficult, as it's just a matter of doing the same thing as now but mounting the auth method in a path that's not the default when we set it up.

I've been thinking about this recently as the IAM method was also lacking mount_path support (oversight on my end, not an HVAC issue ; see #7 ), and there was no test for that either.

So one way to do this is to duplicate the config of every auth method, one with default mount point and one with a custom, and then run each set of auth method tests against both. It would be thorough but it would basically double testing time.

A more naive test might be to mount every auth method on a non-default path and always use the mount_point parameter in tests. I am slightly worried we would miss some edge case where this plugin doesn't work correctly with the default mount, due to oversight on our part, unexpected behavior from hvac, or other.

I'll think a little on how to implement tests for this and the general issue of mount_point issues.
Thanks for reporting!

from community.hashi_vault.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.