Please allow me to generate the inventory_hostname about azure

[cognifloyd]

Maybe one way to do this, would be to allow adding inventory_hostname to hostvar_expressions:

azure/plugins/inventory/azure_rm.py

Line 328 in 4467d13

constructable_config_compose = self.get_option('hostvar_expressions')

And do something like:

compose_inventory_hostname = constructable_config_compose.pop("inventory_hostname")

And pass that to get_hostname here:

azure/plugins/inventory/azure_rm.py

Line 333 in 4467d13

inventory_hostname = self._get_hostname(h)

inventory_hostname = self._get_hostname(h, compose_inventory_hostname, strict=constructable_config_strict)

Then _get_hostname would change to something like this:

def _get_hostname(self, host, compose=None, strict=False):
    if not compose:
        return host.default_inventory_hostname
    try:
        return self._compose(compose, h.hostvars)
    except Exception as e:
        if strict:
            raise AnsibleParserError("Could not generate inventory_hostname for host %s from hostvar_expressions.inventory_hostname: %s" % (host.default_inventory_hostname, to_native(e)))
        return host.default_inventory_hostname

Any comments on doing it like this? Or would using something other than hostvar_expressions be preferrable?

[mwinfie]

Can a maintainer review this? I think this would solve a similar issue we are having where we want to be able to pull in hosts by ip address instead of the vm name.

[Fred-sun]

Can a maintainer review this? I think this would solve a similar issue we are having where we want to be able to pull in hosts by ip address instead of the vm name

This PR has been reviewed and will be merged soon. Thank you!