Comments (2)
If we only depend librustzcash as zcash_primitives in masp_primitives. And in masp and masp_proofs, we use masp_primitives::zcash_primitives::* instead of zcash_primitives::*.
Would it be better?
from masp.
I don't think this really helps much. The benefit of importing the external zcash_primitives crate is that it is immediately obvious which code has been modified, whereas if we copy it into our repository, it requires manual diff to check this fact.
Actually, if anything, I would like to reduce the number of lines of code in our repository as it makes auditing and maintenance easier.
from masp.
Related Issues (14)
- Update README to briefly explain the MASP project HOT 2
- Bundle proving and verifying key in binary HOT 9
- Write specifications, implementations, and testing for Convert circuit and incentive mechanism HOT 2
- Unify specifications HOT 1
- MASP visuals on GitHub HOT 2
- Deprecate libmasp crate? HOT 1
- Output params parse error
- Check for cases of i64/u64 overflow in note values HOT 3
- Refine circuit tests
- Change MASP spec title and file name HOT 1
- Update README to reflect inclusion of convert circuit & recent audit
- get rid of wagyu-zcash-parameters
- Mathematical question about value commitment HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from masp.