Coder Social home page Coder Social logo

Manage librustzcash dependency about masp HOT 2 CLOSED

anoma avatar anoma commented on May 24, 2024
Manage librustzcash dependency

from masp.

Comments (2)

XuyangSong avatar XuyangSong commented on May 24, 2024

If we only depend librustzcash as zcash_primitives in masp_primitives. And in masp and masp_proofs, we use masp_primitives::zcash_primitives::* instead of zcash_primitives::*.
Would it be better?

from masp.

joebebel avatar joebebel commented on May 24, 2024

I don't think this really helps much. The benefit of importing the external zcash_primitives crate is that it is immediately obvious which code has been modified, whereas if we copy it into our repository, it requires manual diff to check this fact.

Actually, if anything, I would like to reduce the number of lines of code in our repository as it makes auditing and maintenance easier.

from masp.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.