Comments (2)
@Cephian noticed that if we aren't able to read the length of a song, we just skip calculating it:
Lines 115 to 126 in e24df5f
Next steps would be to go through all of the songs in Busty's 22 and see if the bot fails to read the length of any of them.
from busty.
So it turns out that MutagenFile
inherits from DictMixin, which means that a fully-populated MutagenFile
may resolve to {}
.
Hence our if audio
conditional in the code above can translate to if {}
, which resolves to False
... even if audio
contains file information. The solution is to check whether audio
is explicitly None
, instead of just falsey.
from busty.
Related Issues (20)
- Send bust messages in channel where command was sent, not channel where files were listed
- Add 'Ending time of bust' to /info command
- Correctly detect the length of songs with incorrect file extensions
- Command to add to queue submissions after bust has begun. HOT 2
- Don't nag the user to vote if Google Form wasn't generated
- Add channel argument to /info which automatically lists
- The bot can fail to play songs when Discord's API is slow
- Unit testing with mock interactions HOT 2
- Bust playback broken through Discord Stages. HOT 2
- Google Forms cannot be viewed until an authorised google user attempts to edit it HOT 2
- Document LLM abilities
- Add top N submitters to /info
- Split long messages into paragraphs
- Stop/reduce impersonation
- Make Busty auto-accept requests onto stage during post-bust HOT 2
- Exceptions are not printed when they happen
- DALL-E Integration (GPT)
- Some song names are missing HOT 1
- Take mutagen dependency off git version
- Handle missing permissions with DM
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from busty.