Comments (25)
The line tool doesn't appear to be working in the regular Annotorious, any ideas where to start troubleshooting? or, any plans to add it as an official plugin? Per @akshayp0's earlier comment, all selector pack annotation tools except line work fine.
It works as I said before. I had to build it with annotorious source code, not openseadragon. Look at my repo and run the index.html https://github.com/ufuk23/annotorious-OpenseaDragon . It uses selector-pack that contains line and the other tools without any issue 👍
from annotorious-v2-selector-pack.
hi @rsimon the line tool is working fine with the osd.html
example when i disable giga pixel mode, maybe the issue is in our code, we will try to debug it
from annotorious-v2-selector-pack.
The line tool didn't exist yet when the last release was publishe. I think it's good to go, though. I'll to see if I can test (and create a new release) soon-ish. The build should work however. (Just tested and there's nothing broken with it in principle.)
What problem are your seeing when you do npm run build
? Did you run npm install
before? You'll definitely also need up-to-date versions of node and npm. I just tested with node 16.16 and npm 8.15.
from annotorious-v2-selector-pack.
I get some runtime errors trying to build selector project. Is it the right way to use commands 'npm install' and 'npm run build' for this project as well?
Then I try another way and put the line folder to the annotorious project and build it with npm. It seems it works with this way but some issues exist. Now I can create a line but cannot update or move it, it doesn't allow me to select :) I am confused and dont know how to do it
from annotorious-v2-selector-pack.
Yes, exactly.
- Clone the repository
npm install
npm run build
Output JS should be in the /dist
folder.
Hm... I'll test. It might be that the line tool is indeed still unfinished at the moment.
from annotorious-v2-selector-pack.
Hi, thank you for your interest 👍 I try it on another PC, (here are the versions npm v9.1.2 node v18.12.1 and the Error)
That seems like a compilation error, but I can build the other annotorious projects similarly.
- When do you plan to release the new version of the selector-pack that includes the line tool?
- Would you mind sending me the latest annotorious-selector-pack.min.js file that includes the line tool you have?
from annotorious-v2-selector-pack.
By the way, when I try to build the "annotorious-openseadragon" project, I think I get some issues because of an outdated code. It tells me the error is about "pointInLine" like below and I realize it doesn't exist in the annotorious-openseadragon project. Then I replace it with the latest "annotorious" source code and it can be build and work now. I mean line tool works when I put it in the tools folder and add some line for ToolRegistry.js file. I think it works using in the selector-pack without changing the "annotorious" project source code.
WARNING in ./src/AnnotationStore.js 117:11-22
export 'pointInLine' (imported as 'pointInLine') was not found in '@recogito/annotorious/src/util/Geom2D' (possible exports: pointInCircle, pointInEllipse, pointInPolygon, polygonArea, polygonInPolygon, svgPathToPolygons)
from annotorious-v2-selector-pack.
hi @rsimon
is the line tool ready for use ? if not can you help me implement this feature
from annotorious-v2-selector-pack.
The line tool should be available in the latest source. If you build the selector pack yourself (npm install -> npm run build), the tool should be available. Did you try that?
from annotorious-v2-selector-pack.
i tried with the latest source but i was not able to draw line using annotorious-openseadragon, i can select line tool & select points for drawing the line but the line doesn't get saved
from annotorious-v2-selector-pack.
Does saving work for other shapes? Per default, annotations that don't have any content (=a comment or a tag) don't get saved. If you want to be able to save "empty" annotations, you need to initialize with the allowEmpty
init option. (See here: https://recogito.github.io/annotorious/api-docs/annotorious/#initialization). Does this change anything?
from annotorious-v2-selector-pack.
I was able to draw the line but the line wasn't selectable , rotatable and extendable as in other shapes.
from annotorious-v2-selector-pack.
Hm, the latest version of AnnotoriousOSD (2.7.10) should support selecting of line shapes. (2.7.9 didn't.) So, at least, the popup box should open. But, yes, it's work in progress, and a 3rd party contribution. I'm not sure if editing functionality has been added yet. (And don't currently have the time to do this myself.)
from annotorious-v2-selector-pack.
No, the latest version doesn't support selecting line shape. AnnotoriousOSD throws Unsupported SVG shape type: line
. There is no line support in the source code https://github.com/recogito/annotorious-openseadragon/blob/main/src/gigapixel/index.js
from annotorious-v2-selector-pack.
Oh, yes - you are right. It lacks support for line shapes in Gigapixel mode. Should work in normal mode I think. How big is your image?
from annotorious-v2-selector-pack.
it is a tiled deep zoomable image
from annotorious-v2-selector-pack.
Do you have the "gigapixelMode: true" option enabled? And, if so, does disabling it change anything?
from annotorious-v2-selector-pack.
yes it is set to true, disabling it doesn't change anything (annotations for square, circle work & line still doesn't work)
from annotorious-v2-selector-pack.
Ok, you mean none of the selector pack annotation tools work? Or JUST the line tool? Do you mean you are not able to draw those shapes? Or select them if they already exist? Also, are you enabling the tools programmatically, with your own code? Or are you using the toolbar plugin?
from annotorious-v2-selector-pack.
all selector pack annotation tools except line work fine
from annotorious-v2-selector-pack.
Ah - sorry, I misread your last message. Ok, thanks for reporting. As I said, I don't know what's the current state of progress on the line tool. I had assumed that it works in normal (=not gigapixel) mode - which doesn't seem to be the case. I'll put it on the list. But can't promise I'll have the time to look into it soon :-(
from annotorious-v2-selector-pack.
I can try to implement this, what do i have to understand in the code to get started ?
from annotorious-v2-selector-pack.
The line tool doesn't appear to be working in the regular Annotorious, any ideas where to start troubleshooting? or, any plans to add it as an official plugin? Per @akshayp0's earlier comment, all selector pack annotation tools except line work fine.
from annotorious-v2-selector-pack.
@rsimon looks like you just fixed that?
from annotorious-v2-selector-pack.
Yes, I finally published a new release, with the dependencies sorted out properly. Everything should be good to go now, including the line tool.
from annotorious-v2-selector-pack.
Related Issues (18)
- Multipolygon annotation tool HOT 3
- Point annotation tool HOT 9
- Register the RubberBandCircleTool in the ToolsRegistry HOT 4
- Free draw tool naming HOT 7
- Circle Annotation Tool Causes Error On Clicking OK HOT 1
- Fixing the starting point of the circle HOT 3
- Issue with executing `npm start` command. HOT 1
- Integrating annotorius selector pack with openseadragon HOT 2
- Prepare svg element option for point annotation representation
- Selecting to the left or up with the Ellipse tool HOT 2
- Point tool not working on touch HOT 7
- point tool bug HOT 5
- polygon will not allow movement
- Circle and eclipse selectors don't have a widget HOT 10
- Console errors when drawing Ellipse HOT 1
- @recogito/annotorious-selector-pack ellipse has a bug, hope the author can fix it
- When I draw a line with polygon, I can't edit it
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from annotorious-v2-selector-pack.