Comments (4)
Next time, definitely ask early in the Facebook group, I can probably save you a lot of time.
Your implementation is generally excellent from a code quality perspective (which is great), but I don't like that you completely dodged any custom cells in your filter view. A major point of the homework was managing embedded controls in custom cells and tying the control events back to your model.
Can you revisit this and add a custom cell to your filters with a UISwitch that is bound to some data? By the way, you should consider discussing homework with your group, Liron's homework is outstanding, haven't seen Ning's homework yet.
from yelply.
Sure I can add the custom TableCell later this week. That probably makes
more sense and explains why FiltersView code is such a mess.
On Wednesday, March 26, 2014, Timothy Lee [email protected] wrote:
Next time, definitely ask early in the Facebook group, I can probably save
you a lot of time.Your implementation is generally excellent from a code quality perspective
(which is great), but I don't like that you completely dodged any custom
cells in your filter view. A major point of the homework was managing
embedded controls in custom cells and tying the control events back to your
model.Can you revisit this and add a custom cell to your filters with a UISwitch
that is bound to some data? By the way, you should consider discussing
homework with your group, Liron's homework is outstanding, haven't seen
Ning's homework yet.Reply to this email directly or view it on GitHubhttps://github.com//issues/1#issuecomment-38659013
.
Sent from my iPhone
from yelply.
@timothy1ee just added the custom Filter cells
from yelply.
Great, looks good.
from yelply.
Related Issues (1)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from yelply.