[BUG]: Front card template android-app:// links not working in Preview screen since 2.18.0 about anki-android

[david-allison]

This is a regression and we'll handle it

This wasn't a planned deprecation of functionality. We shouldn't break downstream decks (with the exception of necessary re-aligning with upstream Anki changes/functionality)

@hanpingchinese I'm a little stretched for time, please follow up if you don't see a PR by Sunday

[hanpingchinese]

anki-bug-16405.mp4

[david-allison]

@BrayanDSO

Relevant:

Anki-Android/AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.kt

Lines 2407 to 2462 in 5d81a57

	var intent: Intent? = null
	try {
	if (url.startsWith("intent:")) {
	intent = Intent.parseUri(url, Intent.URI_INTENT_SCHEME)
	} else if (url.startsWith("android-app:")) {
	intent = Intent.parseUri(url, Intent.URI_ANDROID_APP_SCHEME)
	}
	if (intent != null) {
	if (packageManager.resolveActivityCompat(
	intent,
	ResolveInfoFlagsCompat.EMPTY
	) == null
	) {
	val packageName = intent.getPackage()
	if (packageName == null) {
	Timber.d(
	"Not using resolved intent uri because not available: %s",
	intent
	)
	intent = null
	} else {
	Timber.d(
	"Resolving intent uri to market uri because not available: %s",
	intent
	)
	intent = Intent(
	Intent.ACTION_VIEW,
	Uri.parse("market://details?id=$packageName")
	)
	if (packageManager.resolveActivityCompat(
	intent,
	ResolveInfoFlagsCompat.EMPTY
	) == null
	) {
	intent = null
	}
	}
	} else {
	// https://developer.chrome.com/multidevice/android/intents says that we should remove this
	intent.addCategory(Intent.CATEGORY_BROWSABLE)
	}
	}
	} catch (t: Throwable) {
	Timber.w("Unable to parse intent uri: %s because: %s", url, t.message)
	}
	if (intent == null) {
	Timber.d("Opening external link \"%s\" with an Intent", url)
	intent = Intent(Intent.ACTION_VIEW, Uri.parse(url))
	} else {
	Timber.d("Opening resolved external link \"%s\" with an Intent: %s", url, intent)
	}
	try {
	startActivity(intent)
	} catch (e: ActivityNotFoundException) {
	Timber.w(e) // Don't crash if the intent is not handled
	}

[BrayanDSO]

Why hanping doesn't use standard Android deep links? We are not in 2016 anymore. You can tell your app to accept android-app:// links without depending on AnkiDroid or any other app.

I don't see why such a scheme should be handled in AnkiDroid's end.

[hanpingchinese]

There are still legacy APKs out there that rely on android-app:// so regardless of how things should be done now, it's still worth supporting IMO.

Also it's worth noting that the android-app scheme has not been deprecated.

Should the scheme be handled in AnkiDroid's end? Yes, for the reason that it has done so historically and AnkiDroid has always been strong at supporting legacy decks.

Side note: one main reason of using android-app scheme is the ability to target a specific app. Furthermore, the app has multiple flavors some of which would potentially share the same deep links. I know it's possible to work around all this, but things get messy quickly.

Regardless, I hope the legacy factor mentioned above should be enough for this to be treated as a bug worth fixing.

[hanpingchinese]

Just one more point. If an app handles the android-app scheme, then you end up with an Intent chooser because Google app also supports that scheme.

[BrayanDSO]

that it has done so historically and AnkiDroid has always been strong at supporting legacy decks.

I don't think that sticking to the past per se is a reason for keeping features. Otherwise, Chess notation should be restored and the legacy TTS should be undeprecated, since they break a lot of decks and the workarounds are way harder than adding a simple deeplink, and need to be done by the users, not us.

But, the feature is nice because of X and Y, so it should be kept is a valid reason and I'm fine with it.

I still recommend deeplinks as a failproof measure instead of depending on AnkiDroid to avoid situations like this one.

[MorenoTropical]

Leave it to me