Remove proptypes from production build about react-infinite-scroll-component

[ankeetmaini]

Thanks so much for this suggestion. But I think this should be done in userland code, in their webpack configs, else they won't get any warnings! I don't run the code via uglify because then users would not have either sourcemaps or debugging ability.

Let me know!

[mrchief]

But I think this should be done in userland code, in their webpack configs

Ideally yes. But webpacking already webpacked code can lead to issues (not sure it does in this case - I'll know once i give it try). Are you planning to support package.module or package.jsnext:main which exposes the non webpacked files?

The ideal solution would be to do what react does - expose a dev build and a prod build. It's more work for us library authors though. (I'm currently debating the same for my component - whether to keep proptypes or not, whether to minify or not etc. etc.)

[ankeetmaini]

Yes I've been planning to expose jsmain modules. I'll take a look at react's packaging and try it out! Thanks

…

On Wed, May 30, 2018, 2:11 AM Hrusikesh Panda ***@***.***> wrote: But I think this should be done in userland code, in their webpack configs Ideally yes. But webpacking already webpacked code can lead to issues (not sure it does in this case - I'll know once i give it try). Are you planning to support package.module or package.jsnext:main which exposes the non webpacked files? The ideal solution would be to do what react does - expose a dev build and a prod build. It's more work for us library authors though. (I'm currently debating the same for my component - whether to keep proptypes or not, whether to minify or not etc. etc.) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#63 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGWDl9xfa9PksVKUM5A4mMFLKoo6kz3Pks5t3bJvgaJpZM4UQqnS> .

[ankeetmaini]

#126