Coder Social home page Coder Social logo

Comments (13)

Anidetrix avatar Anidetrix commented on May 18, 2024 1

Hi again @garand,

This feature is available now, in version 3.10.0! To enable it use treeshakeable option:

styles({ mode: ["inject", {treeshakeable: true}] })

I gave myself a week to come up with something better, but in the end getter-based approach seems like the best compromise for now. Also, to inject global styles without using any classes, use it like so:

import styles from "./style.css"
styles.inject()

Let me know if that works for you!

from rollup-plugin-styles.

Anidetrix avatar Anidetrix commented on May 18, 2024 1

Great! I don't see 3.10.0 yet, is that still being deployed?

Yes

[!] (plugin styles) Error: Unable to load PostCSS plugin 0

This was also fixed in 3.10.0

from rollup-plugin-styles.

garand avatar garand commented on May 18, 2024 1

Already installed and trying it now. I'll let you know if it's doing what I expect!

from rollup-plugin-styles.

garand avatar garand commented on May 18, 2024 1

Seems to be working just great so far. Will make additional issues later if I discover any functionality that is missing. Thanks for the hard work. 🙌

from rollup-plugin-styles.

Anidetrix avatar Anidetrix commented on May 18, 2024

Hi @garand,

If your mean class exports - at the time, object treeshaking is not yet supported by rollup (see here for details), but there are alternative solutions for this:

  1. Use named exports
    or
  2. Use rollup-plugin-terser

If you are talking about stripping unused CSS - consider code splitting using dynamic imports or manual chunks, or try PurgeCSS.

As of injecting only parts of styles - does it even make sense since the CSS is already bundled inside JS loaded into browser? (EDIT: See the comment below)

Please inform me if you have an argument about why it should be different or if I got something wrong.

Hope it helps!

from rollup-plugin-styles.

Anidetrix avatar Anidetrix commented on May 18, 2024

Looking through the provided plugin again, I think I now understand what this accomplishes. By the way, it is not connected to injector, but to generated embedding code. Shouldn't be too hard to implement actually, so I'll try.

Also, I think using object getters/setters would be a better approach, don't you think? It would not cause any breaking changes and will keep syntax clean.

UPDATE 1: Seems this will also require an additional option since with this approach CSS won't be injected at all, even the global one, unless classes are referenced inside code. Also it probably won't be compatible with named exports unless they are wrapped in individual functions. So if anyone knows a better solution I'm all ears!

from rollup-plugin-styles.

garand avatar garand commented on May 18, 2024

@Anidetrix This is awesome! I'll try it out right now. Do I need to run .inject() or can I call it like I referenced in the initial issue comment?

from rollup-plugin-styles.

Anidetrix avatar Anidetrix commented on May 18, 2024

@garand Use .inject() only if you don't use any classes from the file and you still want it to be injected.

If you use any class, like so:

import styles from "./style.css"
console.log(styles.anyClassName)

CSS will be injected automatically.

from rollup-plugin-styles.

garand avatar garand commented on May 18, 2024

Great! I don't see 3.10.0 yet, is that still being deployed?

Also... all of a sudden I am getting this error recently:

[!] (plugin styles) Error: Unable to load PostCSS plugin `0`

Not sure what would be causing it. This is my postcss.config.js. That config is working fine in other projects and all of the dependencies are installed.

module.exports = {
  plugins: [
    require('postcss-import'),
    require('postcss-edgie'),
    require('tailwindcss'),
    require('postcss-preset-env')({ stage: 0 }),
    require('autoprefixer'),
  ],
}

I can create a separate issue if needed.

from rollup-plugin-styles.

Anidetrix avatar Anidetrix commented on May 18, 2024

3.10.0 is up if you haven't seen yet, hope this is what you were looking for!

from rollup-plugin-styles.

garand avatar garand commented on May 18, 2024

@Anidetrix For that PostCSS plugin issue... it came up again, I cleared out node_modules, installed again, and then it built fine... Any ideas? Seems to come up periodically.

from rollup-plugin-styles.

Anidetrix avatar Anidetrix commented on May 18, 2024

@garand I believe this should not be the case since code for that isn't particularly complex, probably package manager just messed up. But if the issue will appear on a regular basis I can investigate more thoroughly.

from rollup-plugin-styles.

garand avatar garand commented on May 18, 2024

Okay, sounds good. I'll let you know if it keeps coming up. Appreciate the quick responses!

from rollup-plugin-styles.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.