Comments (5)
I've edited the issue to provide a minimal structural directive that reproduces the issue. All it takes is the following, which looks quite innocent to me:
export class FooDirective implements OnInit {
private tpl = inject(TemplateRef);
private vcr = inject(ViewContainerRef);
ngOnInit() {
Promise.resolve().then(() => {
this.vcr.createEmbeddedView(this.tpl, {});
});
}
}
from angular.
Thank you for the excellent minimal reproduction.
Yep, this is indeed a bug. Digging in, the problem seems to be with the ChangeDetectorRef
trick we're using in effect()
to know if we're inside a view that has been initialized or not.
When BugDirective
calls effect()
, we use the LView
to decide if the first update pass is already complete (see the code). The ChangeDetectorRef
though gives us the LView
of the parent component, which of course has already been initialized. Thus we don't defer the effect from scheduling immediately, causing the issue.
from angular.
Hi JB !
Is there any reason you opened the issue on the FW and not the transloco repo ? Structural directives provided by the framework like NgIf don't have this issue. It look like it's a problem the way transloco projects the content of the directive.
from angular.
Hi Matthieu
I assumed that whatever Transloco is doing in its directive shouldn't have an impact on how Angular schedules the execution of an effect: it should be executed after the input has been set, and not before.
Isn't that a reasonable assumption?
from angular.
The first effect execution is scheduled to run during the first CD. Transloco is probably triggering a CD before the input has been set.
from angular.
Related Issues (20)
- Form input mask provided by the framework HOT 6
- [Feature] Introduce Type-safe Token Providing HOT 7
- docs: `inject()` is missing all overloads HOT 2
- Add distinction between model() and model.required() on type level HOT 1
- Standalone Component Exports HOT 1
- Set ViewEncapsulation per module HOT 2
- setting signal outside of angular zone error HOT 3
- View provider/provider info that's logged in the console is incorrect
- No more subclasses or `implements`/`extends` information in API doc
- Missing code blocks in usage notes. HOT 1
- toSignal does not change if new published value passes equality check and there is no way to modify that HOT 2
- ErrorNG8001 ${element} is not know element HOT 11
- FormGroup.reset() input typings are incorrect HOT 2
- ErrorHandler docs don't have standalone alternative HOT 2
- Allow one time binding input HOT 1
- Missing example code for accessibility best practices case study HOT 1
- PromiseRejectionEvent not fired
- feat(signal_effect with explicit deps): introduce a new "watch" func having explicit signal_deps and skipFirstCallback HOT 4
- Generate Error routes at build time.
- Page not found for https://angular.dev/assets/tutorials/common HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular.