Drag position is calculated incorrectly when parent elements has margins/paddings and defined position about ui-layout

[nevcos]

I've fixed this issue changing mouseMoveHandler code, please test-it with above code:

From bfc38051ba3eaca73a56ce5e4271c53d20a17e6d Mon Sep 17 00:00:00 2001
From: Filipe Costa <[email protected]>
Date: Mon, 1 Dec 2014 22:43:19 +0000
Subject: [PATCH] Fix #60 - Drag position is calculated incorrectly when parent
 elements has margins/paddings and defined position.

---
 src/ui-layout.js | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/ui-layout.js b/src/ui-layout.js
index cd2b0ca..a2f256d 100644
--- a/src/ui-layout.js
+++ b/src/ui-layout.js
@@ -108,10 +108,13 @@ angular.module('ui.layout', [])
     };

     ctrl.mouseMoveHandler = function(mouseEvent) {
-      lastPos = mouseEvent[ctrl.sizeProperties.mouseProperty] ||
+      var lastMousePos = mouseEvent[ctrl.sizeProperties.mouseProperty] ||
       (mouseEvent.originalEvent && mouseEvent.originalEvent[ctrl.sizeProperties.mouseProperty]) ||
       (mouseEvent.targetTouches ? mouseEvent.targetTouches[0][ctrl.sizeProperties.mouseProperty] : 0);

+      var lastRelativePos = lastMousePos - $element.offset()[ctrl.sizeProperties.flowProperty];
+      lastPos = lastRelativePos;
+
       //Cancel previous rAF call
       if(animationFrameRequested) {
         window.cancelAnimationFrame(animationFrameRequested);
-- 
1.9.4.msysgit.2

Thanks!

[nevcos]

Just to clarify, $element.offset function is the jQuery offset function, but jQuery is not defined as a dependency, so this could be a problem.

[mindjuice]

I've provided a similar patch in #52 that does not require jQuery.

[jbro-io]

@nevcos can you confirm v1.0.5 fixes this issue? Thansk!

[nevcos]

Hi @jbroquist, sorry about the (very) late response.

Successfully tested with master and version 1.0.5 👍

Thanks!