Coder Social home page Coder Social logo

Comments (14)

DWand avatar DWand commented on May 20, 2024

And what if there are no access to the Enternet, for example?

2013/5/14 Pascal Precht [email protected]

There are plunks. That's enough.


Reply to this email directly or view it on GitHubhttps://github.com//issues/49
.

from angular-translate.

0x-r4bbit avatar 0x-r4bbit commented on May 20, 2024

The code is documented well enough. If we really wanna provide a demo folder, then we should at least re-structure it by example.

from angular-translate.

knalli avatar knalli commented on May 20, 2024

Actually, IMHO, it is sometimes more comfortable to dev/test/try out something against existing demo or samples.

And, separated demo at Plunkr has one drawback: They are not version aware. It is sometimes really hard to find out how a piece of software should work in a non-latest version. You won't support Plunkers to all version, will you? :)

Yeah, we have tests. But nobody want read them to find out how the plugin works. At least, they aren't reality aware. They are the technically reference tests.

from angular-translate.

0x-r4bbit avatar 0x-r4bbit commented on May 20, 2024

I'm okay with that. So, demos have to be re-structured.

from angular-translate.

0x-r4bbit avatar 0x-r4bbit commented on May 20, 2024

I've updated the issue title.

from angular-translate.

DWand avatar DWand commented on May 20, 2024

Are there any proposals about the correct structure?

from angular-translate.

0x-r4bbit avatar 0x-r4bbit commented on May 20, 2024

Nope. I would simply go like

demo
| - example1
| - example2

etc.

from angular-translate.

knalli avatar knalli commented on May 20, 2024

I'd say: Each demo case should have its own environment (they will share all common js sources) with a specific name about what it will demonstrate.

from angular-translate.

DWand avatar DWand commented on May 20, 2024

As a variant 3703627

from angular-translate.

knalli avatar knalli commented on May 20, 2024

Yeah 👍 :) More structured than before, with additional comments. Looks very good.

I'd not use white spaces in urls.. sometimes has issues. Replace it with _.

from angular-translate.

DWand avatar DWand commented on May 20, 2024

Ok, I'll try to fix it tomorrow.

from angular-translate.

0x-r4bbit avatar 0x-r4bbit commented on May 20, 2024

@DWand thanks a lot man! Like @knalli said, the file names shouldn't contain whitespaces. Replace the whitespaces with underscores, and I'll merge this soonish into canary :)

from angular-translate.

DWand avatar DWand commented on May 20, 2024

Here it is #51.
Spaces are replaced with underscores in file names.
And, actually, I don't know German. So, I replaced it to Russian in demos. Hope you will not be offended by this.

from angular-translate.

0x-r4bbit avatar 0x-r4bbit commented on May 20, 2024

MERGED

from angular-translate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.