Comments (5)
Could you release a 9.0.1 version with this fix?
from platform.
Probably, I was not clear enough with the case I have.
You're right that when you build the package it doesn't included into bundle.
But it still required by DevToolsExtension
(dev-tools.ts file imports type definition). And in runtime you will have an error, because this import can't be resolved.
I don't mind to have redux-devtools-extension
as DevDependency in my project. But if I build my project - I won't be able to run my project on other environments due to missing imports/references...
Am I missing something?
from platform.
Solved by #58
from platform.
Just playing with a release 10.0.0 and found interesting thing: redux-devtools-extension
added as a devDependency, but it's required as a dependency. And it makes my project to have this dependency as well.
I've created an issue to track that (#84).
from platform.
but it's required as a dependency
Can you elaborate on that? I think it's only added as a DevDependency.
What is the exact issue? Do you mind it being installed in your project?
Edit:
Actually it should not affect our Angular bundle size, as we only import a type definition of redux-devtools-extension
(which is stripped away by tsc on transpilation).
To be sure about this and inspect the size taken in your bundle by a package you can use ng build --prod --stats-json
combined with webpack-bundle-analyzer
.
from platform.
Related Issues (20)
- Compiler errors when importing NgReduxModule - missing @NgModule annotation HOT 2
- angular-redux/store error with won't compile with rxjs 6.4.0/redux 4.0.4 HOT 1
- connect directive cannot read property controls of undefined as it is checking for this.form and not this.formGroup HOT 5
- Redux Devtools angular 8 HOT 1
- Dispatch an action outside of ngZone HOT 1
- Angular Upgrade from v7 to v8 Peer Dependency issue HOT 4
- Support Ivy compiler for redux-router
- Substore with Provide Store doesn't work
- Angular 9 support HOT 5
- Observable updates aren't reflected in templates HOT 5
- Is this project dead? HOT 23
- repo marked as unmaintained HOT 1
- 'formDirective' is defined as an accessor in class 'ControlContainer', but is overridden here in 'ConnectArray' as an instance property. HOT 1
- Unit Testing: MockNgRedux.getSelectorStub for @select with state => someFn(state) HOT 2
- Angular v8 support HOT 14
- Reactive Forms broken in Version 10 of angular-redux/forms HOT 1
- Throwing error while trying to use angular-redux HOT 5
- Class NgRedux incorrectly implements interface RootState HOT 3
- Remove immutable.js as a direct dependency of @angular-redux/form
- When navigating by UPDATE_LOCATION guards are ignored HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from platform.