Coder Social home page Coder Social logo

Comments (5)

fvilers avatar fvilers commented on June 11, 2024 2

Could you release a 9.0.1 version with this fix?

from platform.

MaKCbIMKo avatar MaKCbIMKo commented on June 11, 2024 2

Probably, I was not clear enough with the case I have.

You're right that when you build the package it doesn't included into bundle.

But it still required by DevToolsExtension (dev-tools.ts file imports type definition). And in runtime you will have an error, because this import can't be resolved.

I don't mind to have redux-devtools-extension as DevDependency in my project. But if I build my project - I won't be able to run my project on other environments due to missing imports/references...

Am I missing something?

from platform.

wtho avatar wtho commented on June 11, 2024

Solved by #58

from platform.

MaKCbIMKo avatar MaKCbIMKo commented on June 11, 2024

Just playing with a release 10.0.0 and found interesting thing: redux-devtools-extension added as a devDependency, but it's required as a dependency. And it makes my project to have this dependency as well.

I've created an issue to track that (#84).

from platform.

wtho avatar wtho commented on June 11, 2024

but it's required as a dependency

Can you elaborate on that? I think it's only added as a DevDependency.

What is the exact issue? Do you mind it being installed in your project?


Edit:

Actually it should not affect our Angular bundle size, as we only import a type definition of redux-devtools-extension (which is stripped away by tsc on transpilation).

To be sure about this and inspect the size taken in your bundle by a package you can use ng build --prod --stats-json combined with webpack-bundle-analyzer.

from platform.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.