Ionic 4: still hitting API about ts-cacheable

[angelnikolov]

Hey @lordcoste, I doubt it that it has something to do with the lazy loading since Cacheable is just a decorator and shouldn't be affected by it and it should start working once it loads lazily. Can you show me how you are invoking getAdvs?

[lordcoste]

sure:

this.placeService.getAdvs(place_id).subscribe((advs) => {
    console.log(advs);
});

[angelnikolov]

Hm, can you put a console.log in your method, like:

@Cacheable()
  public getAdvs(place: number) {
    console.log(place);
    return this.http.get<Adv[]>('http://.../api/v1/advs/' + place)
      .pipe(map(advs => advs.filter(adv => adv.landingUrl !== null)));
  }

and confirm that it really gets called multiple times with the same argument?

[lordcoste]

I see, I'm switching from one place to another:

/api/v1/advs/1
/api/v1/advs/2
/api/v1/advs/1 < here was expecting to be already in cache

if I increase maxCacheCount it works.

Can you confirm that this is the correct behaviour?

Most of my users will have just one place and setting maxCacheCount: 5 will cover everyone.

[angelnikolov]

Yes, this is the correct behaviour.
If you just set it up with @Cacheable({}), i.e - no config, it will cache everything until the method is called with a new parameter - 2 in your case.
If you set the maxCacheCount to 5, it will keep up to 5 parameter/response pairs in the cache.

[lordcoste]

Thank you :)