Reduce size for browser about isomorphic-crypto

[andywer]

Thanks for your feedback!

The points are basically valid, but there is already a browser field in the package.json that points to lib/browser.js which just passes-through crypto-browserify. The process.browser check in the index.js is just to make double-sure. Probably unnecessary.

Looks like webpack uses crypto-browserify to implement crypto (see here). But good catch! Didn't remember that webpack already does that! (Damn webpack magic 😉)

[ai]

there is already a browser field in the package.json

Oops =^_^=

crypto-browserify to implement crypto

Maybe you can use Web Crypto API for browsers. It will reduce size, because crypto-browserify is too big.

[andywer]

Maybe you can use Web Crypto API for browsers. It will reduce size, because crypto-browserify is too big.

Would be nice, but will make quite some effort, especially since the API is not very similar. Seems like the subtle crypto API even is async.

But maybe we should not try to provide crypto in the browser, but rather regard a set of packages (like create-hash & friends) which provide parts of the functionality as the gold standard. They can use crypto in node and be isomorphic. And maybe they should be async.

Anyway, I'm going to bed for now 😉