Comments (8)
I would like to update that I tried with the .skip and .start parameters for querychangeoptions and even that gives 400 Bad Requestpanic
from go-gerrit.
hey @udaycoder,
can you post the code you are using here? This would help us to reproduce this issue.
Next, is the Gerrit instance you are connecting to, publicly available? Or is it hosted in a private environment?
And which version of Gerrit you are using? Which plugins are installed?
from go-gerrit.
Sorry the gerrit instance that I am connecting to wouldn't be publicly available.
The code snippet after successfull authentication is ->
opt := &gerrit.QueryChangeOptions{}
opt.Limit = 2000
opt.Skip = 500
opt.Query = []string{"status:merged"}
changes, _, err = client.Changes.QueryChanges(opt)
if I don't use opt.Skip or opt.Start everything works fine, and I do know there are more changes as the more changes flag is set to true and also from UI gerrit. The version of gerrit REST is 3.0.1.
from go-gerrit.
Update -> Was able to use the skip parameter properly in python, so I guess this is not a server side limitation.
from go-gerrit.
@udaycoder Thanks for the feedback.
Right now I have limited time to re-check this issue. Sorry for this.
Would you mind to post the python code here, that we or the community can reproduce this issue and see how this can be solved in Python?
from go-gerrit.
I used the python library-> https://github.com/dpursehouse/pygerrit2
from go-gerrit.
Thank you. As I wrote, right now I don't have time to look deeper into this.
I keep this issue open and will tackle it in the future when I find the right time.
@community: If you read this, feel free to tackle the issue. If I can support, write down here and I try to do my best!
from go-gerrit.
Hey @udaycoder,
I had a look into it and prepared a fix in #98
I will wait for feedback on this and merge it soon.
Maybe you wanna give this PR a try.
Thanks for reporting. I will close this and we move the discussion to #98
from go-gerrit.
Related Issues (20)
- Update CHANGELOG.md
- Craft a new release HOT 2
- Where to get the revisionID for the GetComment API ? HOT 2
- Projects.SetConfig endpoint fails with 400 Bad Request due to ConfigInput.MaxObjectSizeLimit zero value not being omitted HOT 5
- Contexts HOT 1
- Can't get the library working for repo names containing slashes HOT 1
- `ProjectBaseOptions` improper uri tag for `Skip` field
- API-Methods: Return map/slice directly, rather than a pointer to one
- Proposal: Use Timestamp type for all time fields. HOT 3
- Simpler fix for credentials with characters such as '/'. HOT 2
- Optimize Error-Handling-Code of read body
- labels should not be pre-escaped HOT 3
- All DELETE api calls returns error 400 (Bad request) HOT 5
- Function DeleteDraftChange should be renamed as DeleteChange HOT 1
- Hello? <crickets> HOT 6
- SetReview support for --project option HOT 2
- Document missing OpenAPI/Swagger-Defintion/API-Spec HOT 2
- Error in Projects.CreateProject: PUT a/projects/{name} invalid JSON in request HOT 6
- Add support for context package HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-gerrit.