Coder Social home page Coder Social logo

Comments (7)

andhie avatar andhie commented on August 15, 2024 1

The guideline says Bottom Navigation is suitable if you have 3 to 5 tabs.
As i can see, the app only has 2 top level screen. (unless you can figure out what the 3rd tab does)
In such case, using ViewPager with TabLayout is more suitable instead

https://material.io/design/components/bottom-navigation.html
https://material.io/design/components/navigation-drawer.html

from sunflower.

XinyueZ avatar XinyueZ commented on August 15, 2024

@andhie Also a good idea.

from sunflower.

andhie avatar andhie commented on August 15, 2024

however, i would still prefer to do something that would make use of Navigation (to demo its capability). so i would lean towards BottomNavigation with 3 tabs. perhaps the 3rd tab can be About screen or similar?

from sunflower.

tiembo avatar tiembo commented on August 15, 2024

Thanks for the discussion @XinyueZ and @andhie. Yes, the navigation should move from a Navigation Drawer to Bottom Navigation. In addition to "My Garden" and "Plant List", the additional destination(s) can be a Settings destination and possible an About destination.

Agree right now that it's a bit confusing that the nav drawer is accessible via the plant detail page.

from sunflower.

tiembo avatar tiembo commented on August 15, 2024

Also, https://issuetracker.google.com/issues/80029773 addresses reconciling Navigation and Material guidelines.

from sunflower.

andhie avatar andhie commented on August 15, 2024

Agree right now that it's a bit confusing that the nav drawer is accessible via the plant detail page.

The guideline didnt specify in detail screen that the drawer is not accessible. if you take note, the Google Play Store can access the drawer via edge swipe even in app detail page.

from sunflower.

tiembo avatar tiembo commented on August 15, 2024

Closing outdated issue as the navigation drawer has since been removed.

from sunflower.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.