Comments (7)
The guideline says Bottom Navigation is suitable if you have 3 to 5 tabs.
As i can see, the app only has 2 top level screen. (unless you can figure out what the 3rd tab does)
In such case, using ViewPager
with TabLayout
is more suitable instead
https://material.io/design/components/bottom-navigation.html
https://material.io/design/components/navigation-drawer.html
from sunflower.
@andhie Also a good idea.
from sunflower.
however, i would still prefer to do something that would make use of Navigation (to demo its capability). so i would lean towards BottomNavigation with 3 tabs. perhaps the 3rd tab can be About screen or similar?
from sunflower.
Thanks for the discussion @XinyueZ and @andhie. Yes, the navigation should move from a Navigation Drawer to Bottom Navigation. In addition to "My Garden" and "Plant List", the additional destination(s) can be a Settings destination and possible an About destination.
Agree right now that it's a bit confusing that the nav drawer is accessible via the plant detail page.
from sunflower.
Also, https://issuetracker.google.com/issues/80029773 addresses reconciling Navigation and Material guidelines.
from sunflower.
Agree right now that it's a bit confusing that the nav drawer is accessible via the plant detail page.
The guideline didnt specify in detail screen that the drawer is not accessible. if you take note, the Google Play Store can access the drawer via edge swipe even in app detail page.
from sunflower.
Closing outdated issue as the navigation drawer has since been removed.
from sunflower.
Related Issues (20)
- [Update]: Fix Deprecation on PlantDetailsFragment
- [Bug]: Button Visibility Issue on PlantDetails Screen HOT 1
- [Bug]: Transparent background color on dark theme HOT 1
- [Bug]: The filter icon duplicate HOT 1
- Remove commented code HOT 2
- [Bug]: Incorrect packaging.yaml HOT 3
- [Bug]: Toolbar is not collapsing well on Dark Mode HOT 2
- [Bug]: Release build is not showing any data
- [Bug]: Plus icon not visible on plant details screen at m3 in Dark Mode HOT 2
- window.open('https://play.google.com/store/apps/details?id=<PLAY_PACKAGE_NAME>', '_blank'); HOT 2
- Sunflower
- [Update]: Migrate [Hilt & Room] from KAPT to KSP HOT 2
- [Update]: Clean up Version Catalogs and upgrade dependencies flavours HOT 1
- Update Project Target SDK and Compiled SDK to Api 34
- [Bug]: After pull the latest update, the app getting crashed while selecting the plant list tab and onClick Add plant button. HOT 5
- You can update to chipmunk if you want now that youre on it
- [Bug]: Associated image visibility and scroll acts weird.
- [Bug]: NoClassDefFoundError when instrumented test.
- [Bug]: Performance issue
- Update to Kotlin v2.0 & Compose compiler
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sunflower.