Coder Social home page Coder Social logo

Comments (7)

JoseAlcerreca avatar JoseAlcerreca commented on August 25, 2024

Hi, thanks for your suggestion but, please, read:
https://github.com/googlesamples/android-architecture/blob/master/code-of-conduct.md

from architecture-samples.

gvaish avatar gvaish commented on August 25, 2024

Sure @JoseAlcerreca

I am not sure of the context - what specific section, if any, you want me to read. Or is it more of FYI. :-)

from architecture-samples.

JoseAlcerreca avatar JoseAlcerreca commented on August 25, 2024

We want people to contribute to this project understanding that their mistakes will be fixed, but knowing that their work will be respected. I'm sure you meant "improvable" when you said "lame" :)

I agree with you though, this is not a good practice. However, I prefer a factory method. Agreed?

from architecture-samples.

JoseAlcerreca avatar JoseAlcerreca commented on August 25, 2024

Ping!

from architecture-samples.

gvaish avatar gvaish commented on August 25, 2024

Missed the earlier ping.

Lame = Looks lame & improvable.

And yes - factories are good indirections to start with. I prefer to use service locator pattern than raw factories.
Or even better - use dependency injection.

from architecture-samples.

Rainer-Lang avatar Rainer-Lang commented on August 25, 2024

@gvaish Want to make a PR? 👍

from architecture-samples.

tunjid avatar tunjid commented on August 25, 2024

Closing as obsolete.

from architecture-samples.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.