`Toast` extensions on `Context` about android-ktx

[JakeWharton]

That seems like it sacrifices type safety for no benefit whatsoever. Why wouldn't you use an overload?

[JakeWharton]

Yes

…

On Sat, Sep 1, 2018, 4:41 AM Jemshit Iskenderov ***@***.***> wrote: Hi, is toast extension removed, can't import it using version 1.0.0-rc02? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#143 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEEEUapb0K-8hCFwVV82-lwCy9izOolks5uWkg_gaJpZM4R6JvC> .

[egor-n]

This may be handy, but apps should really stop using Toast since they don't show up if notifications are disabled for an app.

https://issuetracker.google.com/issues/36951147

[MGaetan89]

And instead of two methods, why not one with a duration parameter?

[abbath0767]

i think good solution for duration is default fun argument, like this:

fun Context.toast(messageResId: Int, duration: Int = Toast.LENGTH_LONG) =
        Toast.makeText(this, messageId, duration).show()

[frederickcxa]

We could use also to be able to show and return the Toast.

fun Context.toast(@StringRes resId: Int, duration: Int = Toast.LENGTH_LONG) =
    Toast.makeText(this, resId, duration).also { it.show() }

This gives more flexibility to the API users. 😃

[n8ebel]

a single function with a duration arg & a default value is a nice idea 👍 whether it's added here or not, I'll have to incorporate that 😄

[simonschiller]

I always assumed it was better to create a Toast using the ApplicationContext (see: https://stackoverflow.com/questions/46730738/toast-maketext-activity-or-application-context).

So I would suggest doing something like this:

fun Context.toast(text: CharSequence, duration: Int = Toast.LENGTH_SHORT): Toast =
        Toast.makeText(this.applicationContext, text, duration).apply { show() }

This would also answer the proposal of @mitrejcevski

[avaytsekhovskiy]

I do believe that .apply { show() } should be part of this extension. Even lint thinks that toast should be created to be shown :)

That's how i use it in projects:

 fun Context.toast(message: CharSequence, duration: Int = Toast.LENGTH_SHORT): Toast =
        Toast.makeText(this, message, duration).apply { show() }

toasts are great for visual debugging, not for end user. So i prefer LENGTH_SHORT as default value. What do you think?

[jshvarts]

@MGaetan89 returning an instance of the Toast will give an opportunity for the caller to hide the Toast before time is up by calling toast.cancel()

[avaytsekhovskiy]

@MGaetan89 to return toast object as the result. show() returns Unit, unlike Context.toast() will return created toast instance.

[bernaferrari]

Egor, I'm curious, what is the recommended way? Snackbar?

[jshvarts]

I normally do something similar to what @abbath0767 suggested.

fun Context.toast(@StringRes resId: Int, duration: Int = Toast.LENGTH_LONG) =
    Toast.makeText(this, resId, duration).show()

[JakeWharton]

avoids the need to remember to call show()

Lint guards against this.

[frederickcxa]

What about this?

fun Context.toast(content: Any, length: Int = Toast.LENGTH_SHORT): Toast {
    val message = when (content) {
        is String -> content
        is Int -> getString(content)
        else -> throw IllegalArgumentException("Content must be a String or a String resource id.")
    }

    return Toast.makeText(this, message, length).also { it.show() }
}

Here we can pass a String|String resource id to the method, also we return the Toast object back to the caller. 😃

[frederickcxa]

You right, type safety for the win.

[mitrejcevski]

IMO the toast should not be an extension of Context, but an Activity. The reason is that the Context might not be an Activity context, and some devices (i.e. Samsung, Xaomi) would complain. I've seen that happening recently.

[MGaetan89]

What's the advantage(s) of using also/apply instead of directly show?

[MGaetan89]

@avaytsekhovskiy oh right, I didn't noticed that it became the method's body. Thanks

[illuzor]

@simonschiller maybe like this:

fun Context.toast(text: CharSequence, long: Boolean = false): Toast =
        Toast.makeText(this.applicationContext, text, if (long) Toast.LENGTH_LONG else Toast.LENGTH_SHORT).apply { show() }

[simonschiller]

@illuzor I would argue that a duration parameter is better than a boolean flag, as toast("Lorem Ipsum", Toast.LENGTH_LONG) is more readable than toast("Lorem Ipsum", true)

[JakeWharton]

Was merged.

[jemshit]

Hi, is toast extension removed, can't import it using version 1.0.0-rc02?

[hacker1024]

Yes

Why?