Visibility extensions for View classes about android-ktx

[ouattararomuald]

Personally I use show() and hide() respectively for visibility = View.VISIBLE and visibility = View.INVISIBLE. For View.GONE what comes to my mind is gone() or disappear().

[romainguy]

There is already a pending PR for these

[JakeWharton]

Here's my take: https://github.com/android/android-ktx/compare/jakew/visibility-properties/2018-02-06

I'm not really a fan of the function approach to setting this state because it makes the code more verbose when dealing with booleans from a model or other conditional logic.

[rock3r]

I sometimes add and use isVisible/isInvisible/isGone too

[AkshayChordiya]

We can have:

fun View.visible() {
    visibility = View.VISIBLE
}

fun View.invisible() {
    visibility = View.INVISIBLE
}

fun View.gone() {
    visibility = View.GONE
}

If these look good then I can make a PR.

[abbath0767]

#137 - is first feature what i make in kotlin and use still now. I think they have almost every project and then they just have to be)

[chrisbanes]

@ouattararomuald You're in for a bad time with show() and hide() on FloatingActionButton.

[abbath0767]

Here #146 variant of @ouattararomuald. I use the same naming for current extensions

[ouattararomuald]

@chrisbanes Thanks for pointing this out

[romainguy]

@JakeWharton I like this property based approach. It also solves the naming problem with gone.

[chrisbanes]

+1 to properties.

[tiembo]

👍 for properties

[abbath0767]

Oh, i pushed new commit with solved problems after review from @JakeWharton. But i see new nice idea - change 6 functions to 3 properties. And i see what community likes the idea...