Coder Social home page Coder Social logo

Comments (5)

erev0s avatar erev0s commented on June 18, 2024 1

hey @eybisi first of all thank you for taking a shot to resolve this, really appreciated.
I took a look as well and it was a tricky situation. The root cause was this commit and specifically this line is causing the issue.

This commit removed the internal mutf8 implementation that was available till that point and used the already existing pip package mutf8. This resulted in the cm.get_string(value) here already returning a string object and then calling repr on that string object. The call of repr on the string creates the double quotes. It seems repr is no longer required there. I will verify that the removal of repr does not create any other issues and commit this.

from androguard.

erev0s avatar erev0s commented on June 18, 2024 1

@eybisi perfect, i will close this then.
Keep up the awesome work you do with your project.

from androguard.

eybisi avatar eybisi commented on June 18, 2024

Extra " comes from here. Introduced in commit. Kind.String is already handled in earlier get_kind function and returns inside of single quotes '{}'

Should I PR the removal of second Kind.String handling ?

from androguard.

erev0s avatar erev0s commented on June 18, 2024

@eybisi please verify on your side as well that https://github.com/androguard/androguard/tree/977 fixes the issue and I will merge it.

from androguard.

eybisi avatar eybisi commented on June 18, 2024

Yes it fixes!

from androguard.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.